Conversation
* * initial commit * * Use RediSearch branch mirroring fork * * Code Review - Round #1
…4972) change the number of maxPending requests when changing the number of connections
* * initial commit * * code review
* remove compilation flag (wip) * finish removing compilation flag * remove from tests
ramp-packer 2.5.10
…4964) * Fix inplace deletion in tiered index in vecsim * remove excessive thread iteration log, finalize test * update vecsim version * update vecsim version - fixing bug found in test vecsim with json multi * remove print from test * better logging * test - print warning always * test2 - print warning DEBUG AND CI ENV VARS * use force for env vars * try print instead * print for GHA annotation
Add relaxing installation flags to Rocky platform
cmake fetch boost if not exists
* Support ACL for RediSearch commands - wip * Register RediSearch commands to redis ACL categories * Add tests * Small fix * Add coordinator commands registration * Register underscored commands to ACL as well * Remove dangerous from INFO * Skip test conditioned on redis version * Fix categories according to new evaluation * Remove comments * Fix * Address review * Remove TODOs * Replace macro with function * Wrap with RM_TRY * Fix unit-tests * Touchup * Address review * Address review * Address review * Bump sanitizer and Valgrind to use 7.4 * Address review * Touchups * Remove TODOs * Fix test * Address review * Move hack to src
oshadmi
reviewed
Jan 8, 2025
oshadmi
reviewed
Jan 8, 2025
oshadmi
previously approved these changes
Jan 8, 2025
oshadmi
previously approved these changes
Jan 8, 2025
1. Configure the module parameter search-oss-global-password which is equivalent to the previous OSS_GLOBAL_PASSWORD module parameter. 2. Configure the module parameter search-oss-acl-username which is equivalent to the previous OSS_ACL_USERNAME
oshadmi
approved these changes
Jan 8, 2025
Collaborator
Author
|
/backport |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.0
git worktree add -d .worktree/backport-5129-to-8.0 origin/8.0
cd .worktree/backport-5129-to-8.0
git switch --create backport-5129-to-8.0
git cherry-pick -x 5ca0699b306344f752fa0023b09bdc1b9162e6db |
nafraf
added a commit
that referenced
this pull request
Jan 8, 2025
(cherry picked from commit 5ca0699)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Create CONFIG parameter using the Module Configurations API for each of the existing module configuration parameters that today are managed using FT.CONFIG command.
A clear and concise description of what the PR is solving, including:
Which issues this PR fixes
Main objects this PR modified
Mark if applicable