Skip test_multithread:test_async_updates_sanity with sanitizer #5120
Merged
Skip test_multithread:test_async_updates_sanity with sanitizer #5120
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5120 +/- ##
==========================================
- Coverage 86.30% 86.30% -0.01%
==========================================
Files 190 190
Lines 34604 34604
==========================================
- Hits 29866 29864 -2
- Misses 4738 4740 +2 ☔ View full report in Codecov by Sentry. |
meiravgri
approved these changes
Oct 21, 2024
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
Skip test with sanitizer as fork process does not get cpu and hang test (cherry picked from commit 71e8c42)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
Skip test with sanitizer as fork process does not get cpu and hang test (cherry picked from commit 71e8c42)
Contributor
|
Successfully created backport PR for |
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
Skip test with sanitizer as fork process does not get cpu and hang test (cherry picked from commit 71e8c42)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
…5124) Skip test_multithread:test_async_updates_sanity with sanitizer (#5120) Skip test with sanitizer as fork process does not get cpu and hang test (cherry picked from commit 71e8c42) Co-authored-by: alonre24 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
…#5125) Skip test_multithread:test_async_updates_sanity with sanitizer (#5120) Skip test with sanitizer as fork process does not get cpu and hang test (cherry picked from commit 71e8c42) Co-authored-by: alonre24 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
…5126) Skip test_multithread:test_async_updates_sanity with sanitizer (#5120) Skip test with sanitizer as fork process does not get cpu and hang test (cherry picked from commit 71e8c42) Co-authored-by: alonre24 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
After trying to deflake the test by removing the 30-second timeout for the forkGC in the test, we still see that the test hangs while the child fork process is not running, and we reach the hard test limit of 5 minutes.
Hence, we avoid testing it with sanitizer since this environment seems to not fit this kind of test that relies on low priority process to run.
Mark if applicable