[8.0] MOD-7329: Determine if fields and documents are expired before returning them as valid results #5118
Merged
[8.0] MOD-7329: Determine if fields and documents are expired before returning them as valid results #5118
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #5118 +/- ##
==========================================
- Coverage 86.70% 86.62% -0.09%
==========================================
Files 192 193 +1
Lines 34411 34676 +265
==========================================
+ Hits 29837 30039 +202
- Misses 4574 4637 +63 ☔ View full report in Codecov by Sentry. |
GuyAv46
previously approved these changes
Oct 15, 2024
kei-nan
force-pushed
the
backport-4858-to-8.0
branch
2 times, most recently
from
ff2539f to
706a662
Compare
…ing them as valid results (#4858) * * initial commit * * fix missing case in test_expire.py * * fix coord compilation * * fix doc info test * * try and fix some of the tests * * release iterator * * do not set expiration time in the context of the coordinator since it doesn't have an index spec * * support c++ tests that do not provide spec for iterators * * no point in passing timestamp in coordinator flow * * redis 7.4 version in ci is actually 7.3, for codecov we need our tests to run * * reduce max memory from + 200000 to 150000 * * fix test * * cleanup code * * Code Review: Round #1 * * Add geoshape tests, only pass index instead of pointer to filter ctx * * Add vector test * * Code Review - Round #2 * * try and fix tests * * Code Review - Round #3 * * Fix Sanitizer Build * * Code Review - Round #4 * * Minor change in debug command SET_MONITOR_EXPIRATION * * Code Review - Round #5 * * fix tests * * Code Review - Round #6 * * fix crash * * fix test * * improve field mask translation time * fix compilation * fix compilation error * handle field mask of 64 bit * * Code Review - Round #7 * * fix opening of key edge cases * * free fieldIdToIndex array * Code Review - Round #9 * * fix rebase conflicts * support wild card reader filtering * * mac os: fallback to CLOCK_REALTIME if CLOCK_REALTIME_COARSE is not defined (cherry picked from commit 4a67a87)
MOD-7976: Fix HFE Regression (#5318) * * use new expiration API to avoid regression issues with HFE support when expiration isn't being used * * update sdk to get new hash field expiration API * * set monitorFieldExpiration default based on the existence of `RedisModule_HashFieldMinExpire` * * skip field expiration tests if below 8.0 API * * Code Review Comments * Prevent turning on the monitorFieldExpiration if the API does not exist * * move to run against redis 8.0 (cherry picked from commit bebdeb7)
kei-nan
force-pushed
the
backport-4858-to-8.0
branch
from
1198cc0 to
5ffe76f
Compare
kei-nan
requested review from
nafraf and
raz-mon
and removed request for
raz-mon
nafraf
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #4858