[8.0] Improve Error Message on VecSim Syntax Error - [MOD-7887]#5103
Merged
[8.0] Improve Error Message on VecSim Syntax Error - [MOD-7887]#5103
Conversation
* Add a failing test * fix bug * revert a white-space change * move getting the field down * Update query.c * improve error messages * fix tests * review fix (cherry picked from commit 3e07eff)
2 tasks
GuyAv46
approved these changes
Oct 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #5103 +/- ##
=======================================
Coverage 86.25% 86.25%
=======================================
Files 189 189
Lines 34316 34316
=======================================
+ Hits 29598 29600 +2
+ Misses 4718 4716 -2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #5101 to
8.0.