Improve Error Message on VecSim Syntax Error - [MOD-7887]#5101
Merged
Improve Error Message on VecSim Syntax Error - [MOD-7887]#5101
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5101 +/- ##
==========================================
- Coverage 86.31% 86.29% -0.03%
==========================================
Files 190 190
Lines 34604 34604
==========================================
- Hits 29870 29861 -9
- Misses 4734 4743 +9 ☔ View full report in Codecov by Sentry. |
meiravgri
approved these changes
Oct 10, 2024
GuyAv46
deleted the
guyav-improve_error_message_on_vecsim_syntax_error
branch
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5101-to-2.8 origin/2.8
cd .worktree/backport-5101-to-2.8
git switch --create backport-5101-to-2.8
git cherry-pick -x 3e07eff03cdc481bf77c1d5c7725cdd10c039737 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5101-to-2.6 origin/2.6
cd .worktree/backport-5101-to-2.6
git switch --create backport-5101-to-2.6
git cherry-pick -x 3e07eff03cdc481bf77c1d5c7725cdd10c039737 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-5101-to-2.10 origin/2.10
cd .worktree/backport-5101-to-2.10
git switch --create backport-5101-to-2.10
git cherry-pick -x 3e07eff03cdc481bf77c1d5c7725cdd10c039737 |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
* Add a failing test * fix bug * revert a white-space change * move getting the field down * Update query.c * improve error messages * fix tests * review fix (cherry picked from commit 3e07eff)
Contributor
|
Successfully created backport PR for |
GuyAv46
added a commit
that referenced
this pull request
Oct 10, 2024
* Add a failing test * fix bug * revert a white-space change * move getting the field down * Update query.c * improve error messages * fix tests * review fix (cherry picked from commit 3e07eff)
GuyAv46
added a commit
that referenced
this pull request
Oct 10, 2024
* Add a failing test * fix bug * revert a white-space change * move getting the field down * Update query.c * improve error messages * fix tests * review fix (cherry picked from commit 3e07eff)
GuyAv46
added a commit
that referenced
this pull request
Oct 10, 2024
* Add a failing test * fix bug * revert a white-space change * move getting the field down * Update query.c * improve error messages * fix tests * review fix (cherry picked from commit 3e07eff)
This was referenced Oct 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
Improve Error Message on VecSim Syntax Error - [MOD-7887] (#5101) * Add a failing test * fix bug * revert a white-space change * move getting the field down * Update query.c * improve error messages * fix tests * review fix (cherry picked from commit 3e07eff) Co-authored-by: GuyAv46 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Mark if applicable