Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5099 +/- ##
==========================================
- Coverage 87.75% 87.71% -0.05%
==========================================
Files 202 202
Lines 36213 36220 +7
Branches 150 150
==========================================
- Hits 31780 31771 -9
- Misses 4433 4449 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request is stale because it has been open for 60 days with no activity. |
raz-mon
reviewed
Jan 16, 2025
tests/cpptests/test_cpp_llapi.cpp
Outdated
| ASSERT_EQ(info.numDocuments, 2); | ||
| ASSERT_EQ(info.maxDocId, 2); | ||
| ASSERT_EQ(info.docTableSize, 140); | ||
| ASSERT_EQ(info.docTableSize, 16140); |
raz-mon
approved these changes
Mar 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
Author
|
/backport |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-5099-to-2.8 origin/2.8
cd .worktree/backport-5099-to-2.8
git switch --create backport-5099-to-2.8
git cherry-pick -x b4234edfc5031a996c903a824a51a02c75825925 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-5099-to-2.6 origin/2.6
cd .worktree/backport-5099-to-2.6
git switch --create backport-5099-to-2.6
git cherry-pick -x b4234edfc5031a996c903a824a51a02c75825925 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-5099-to-2.10 origin/2.10
cd .worktree/backport-5099-to-2.10
git switch --create backport-5099-to-2.10
git cherry-pick -x b4234edfc5031a996c903a824a51a02c75825925 |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
* Fix TrieMap Size and Cardinality * Add python tests * Fix cpp test * Fix testKeyTableInfo * Fix DocTable memsize * Fix test_ft_info() * Fix testDocTableInfo() * Add description to DocTable properties * Fix testDocTableInfo() 2 * Fix test_ft_info() 2 * Fix tests 3 * Fix testDocTableInfo() 4 * Fix unit-tests * Update DocTable memory size calculation and related tests * Update DocTable size calculation in tests to include struct size * Remove unneeded memsize update * Fix codespell errors * Fix codespell errors * testDocTableInfo: Use shardsCount instead of cluster nodes * Revert changes related to triemap * Fix codespell ignore comment in test_profile_crash_mod5323 (cherry picked from commit b4234ed)
Contributor
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
MOD-5904: Fix DocTable memsize (#5099) * Fix TrieMap Size and Cardinality * Add python tests * Fix cpp test * Fix testKeyTableInfo * Fix DocTable memsize * Fix test_ft_info() * Fix testDocTableInfo() * Add description to DocTable properties * Fix testDocTableInfo() 2 * Fix test_ft_info() 2 * Fix tests 3 * Fix testDocTableInfo() 4 * Fix unit-tests * Update DocTable memory size calculation and related tests * Update DocTable size calculation in tests to include struct size * Remove unneeded memsize update * Fix codespell errors * Fix codespell errors * testDocTableInfo: Use shardsCount instead of cluster nodes * Revert changes related to triemap * Fix codespell ignore comment in test_profile_crash_mod5323 (cherry picked from commit b4234ed) Co-authored-by: nafraf <[email protected]>
nafraf
added a commit
that referenced
this pull request
Mar 19, 2025
(cherry picked from commit b4234ed)
nafraf
added a commit
that referenced
this pull request
Mar 20, 2025
(cherry picked from commit b4234ed)
nafraf
added a commit
that referenced
this pull request
Mar 21, 2025
(cherry picked from commit b4234ed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes to count the memory allocated for
DMDChain *bucketsas part of DocTable memsize.Which issues this PR fixes
Main objects this PR modified
Mark if applicable