Merged
Conversation
kei-nan
reviewed
Oct 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5079 +/- ##
==========================================
- Coverage 86.30% 86.29% -0.01%
==========================================
Files 190 190
Lines 34601 34601
==========================================
- Hits 29861 29859 -2
- Misses 4740 4742 +2 ☔ View full report in Codecov by Sentry. |
kei-nan
reviewed
Oct 7, 2024
kei-nan
approved these changes
Oct 7, 2024
Collaborator
kei-nan
left a comment
kei-nan
left a comment
There was a problem hiding this comment.
Added one optional comment.
Approved the PR.
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
* fix flakiness * revert whitespace change * add comments (cherry picked from commit f37d21f)
Merged
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
* fix flakiness * revert whitespace change * add comments (cherry picked from commit f37d21f)
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
* fix flakiness * revert whitespace change * add comments (cherry picked from commit f37d21f)
|
Successfully created backport PR for |
Merged
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
* fix flakiness * revert whitespace change * add comments (cherry picked from commit f37d21f)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
Fix flaky test (#5079) * fix flakiness * revert whitespace change * add comments (cherry picked from commit f37d21f) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
Fix flaky test (#5079) * fix flakiness * revert whitespace change * add comments (cherry picked from commit f37d21f) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
Fix flaky test (#5079) * fix flakiness * revert whitespace change * add comments (cherry picked from commit f37d21f) Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
Fix flaky test (#5079) * fix flakiness * revert whitespace change * add comments (cherry picked from commit f37d21f) Co-authored-by: GuyAv46 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Fix flakiness in
test_JSON_RDB_load_fail_without_JSON_modulewhere starting the server raises an exceptionMark if applicable