Fix flaky test_async_updates_sanity - avoid timeout in force invoke GC [MOD-7867]#5071
Merged
Fix flaky test_async_updates_sanity - avoid timeout in force invoke GC [MOD-7867]#5071
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5071 +/- ##
=======================================
Coverage 86.30% 86.30%
=======================================
Files 190 190
Lines 34601 34601
=======================================
Hits 29861 29861
Misses 4740 4740 ☔ View full report in Codecov by Sentry. |
alonre24
changed the title
GuyAv46
reviewed
Oct 1, 2024
meiravgri
reviewed
Oct 1, 2024
GuyAv46
previously approved these changes
Oct 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 6, 2024
…C [MOD-7867] (#5071) * use inf timeout so we wont hang * Guy CR
meiravgri
reviewed
Oct 6, 2024
meiravgri
approved these changes
Oct 6, 2024
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
…voke GC [MOD-7867] (#5080) Fix flaky test_async_updates_sanity - avoid timeout in force invoke GC [MOD-7867] (#5071) * use inf timeout so we wont hang * Guy CR * split helper force invoke GC in test (cherry picked from commit 67e5046) Co-authored-by: alonre24 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
…nvoke GC [MOD-7867] (#5081) Fix flaky test_async_updates_sanity - avoid timeout in force invoke GC [MOD-7867] (#5071) * use inf timeout so we wont hang * Guy CR * split helper force invoke GC in test (cherry picked from commit 67e5046) Co-authored-by: alonre24 <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
…voke GC [MOD-7867] (#5082) Fix flaky test_async_updates_sanity - avoid timeout in force invoke GC [MOD-7867] (#5071) * use inf timeout so we wont hang * Guy CR * split helper force invoke GC in test (cherry picked from commit 67e5046) Co-authored-by: alonre24 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
When we run
forceInvokeGC, there is a default timeout in the debug command that blocks the client, triggering forkGC in the background and then replying. However, we saw that this timeout frequently reached in sanitizer tests, in which case we kill the child fork GC process upon shutting down the environment and the thread running the GC is stuck waiting for the child process pipe.Hence, we move the force GC in the test to run in the background while we update vectors and wait for the fork GC without timeout when finishing the test.
Mark if applicable