MOD-7745: Add Benchmarks For Document And Field Expiration#5030
Merged
MOD-7745: Add Benchmarks For Document And Field Expiration#5030
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5030 +/- ##
=======================================
Coverage 86.30% 86.30%
=======================================
Files 190 190
Lines 34601 34601
=======================================
+ Hits 29861 29863 +2
+ Misses 4740 4738 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kei-nan
force-pushed
the
master_jk_add_expiration_benchmarks
branch
from
8f9b63a to
c348ad0
Compare
Contributor
Automated performance analysis summaryThis comment was automatically generated given there is performance data available. In summary:
You can check a comparison in detail via the grafana link Comparison between master and master_jk_add_expiration_benchmarks.Time Period from 30 days ago. (environment used: oss-standalone)
|
oshadmi
reviewed
Sep 24, 2024
oshadmi
reviewed
Sep 24, 2024
nafraf
reviewed
Sep 25, 2024
oshadmi
reviewed
Sep 29, 2024
oshadmi
reviewed
Sep 29, 2024
oshadmi
previously approved these changes
Sep 29, 2024
* will probably be less deterministic but we want to see how it actually behaves
kei-nan
force-pushed
the
master_jk_add_expiration_benchmarks
branch
from
be57882 to
b7bf7ef
Compare
oshadmi
approved these changes
Sep 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
* * initial commit * * rename internal names * * rename numeric field benchmark * * use second resolution to avoid actually expiring stuff and ruining our dataset * * typo * * add key limitations to benchmarks * * add two tests that will actually expire fields and documents * will probably be less deterministic but we want to see how it actually behaves * * change to a dataset where the __key__ can be effective * * fix benchmark name * * fix benchmark failures * * remove requests limitation * * updated lazy expiration benchmarks description (cherry picked from commit 3aeb659)
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
* * initial commit * * rename internal names * * rename numeric field benchmark * * use second resolution to avoid actually expiring stuff and ruining our dataset * * typo * * add key limitations to benchmarks * * add two tests that will actually expire fields and documents * will probably be less deterministic but we want to see how it actually behaves * * change to a dataset where the __key__ can be effective * * fix benchmark name * * fix benchmark failures * * remove requests limitation * * updated lazy expiration benchmarks description (cherry picked from commit 3aeb659)
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
) MOD-7745: Add Benchmarks For Document And Field Expiration (#5030) * * initial commit * * rename internal names * * rename numeric field benchmark * * use second resolution to avoid actually expiring stuff and ruining our dataset * * typo * * add key limitations to benchmarks * * add two tests that will actually expire fields and documents * will probably be less deterministic but we want to see how it actually behaves * * change to a dataset where the __key__ can be effective * * fix benchmark name * * fix benchmark failures * * remove requests limitation * * updated lazy expiration benchmarks description (cherry picked from commit 3aeb659) Co-authored-by: kei-nan <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
MOD-7745: Add Benchmarks For Document And Field Expiration (#5030) * * initial commit * * rename internal names * * rename numeric field benchmark * * use second resolution to avoid actually expiring stuff and ruining our dataset * * typo * * add key limitations to benchmarks * * add two tests that will actually expire fields and documents * will probably be less deterministic but we want to see how it actually behaves * * change to a dataset where the __key__ can be effective * * fix benchmark name * * fix benchmark failures * * remove requests limitation * * updated lazy expiration benchmarks description (cherry picked from commit 3aeb659) Co-authored-by: kei-nan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add benchmarks for document and field expiration
Which issues this PR fixes
Main objects this PR modified
1.Benchmarks
Mark if applicable