Fix benchmark to use new build path#5026
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5026 +/- ##
==========================================
- Coverage 86.31% 86.30% -0.02%
==========================================
Files 190 190
Lines 34593 34601 +8
==========================================
+ Hits 29860 29863 +3
- Misses 4733 4738 +5 ☔ View full report in Codecov by Sentry. |
raz-mon
reviewed
Sep 17, 2024
raz-mon
reviewed
Sep 17, 2024
GuyAv46
reviewed
Sep 17, 2024
GuyAv46
previously approved these changes
Sep 18, 2024
…ly enabled. Only run >4 primaries if extended if enabled.
Contributor
Automated performance analysis summaryThis comment was automatically generated given there is performance data available. In summary:
You can check a comparison in detail via the grafana link Comparison between master and fix_broken_benchmarks.Time Period from 30 days ago. (environment used: oss-standalone)
|
…l feedback < 30min
…uring we use a redisbench-admin with keepalive on ssh tunnels
…e from cluster tests due to keyspace error check
…uery-non-sortable from cluster tests due to client error. created RediSearch/ftsb#97
fcostaoliveira
approved these changes
Sep 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alonre24
added a commit
that referenced
this pull request
Sep 23, 2024
* Fix benchmark to use new build path * Take Raz's fix for benchmarks * fix default module path * make benchmark fail * fix path * fail external flow * remove fail fast and continue on error * addressing CR * Splitting the standalone work among 6 groups. Only profile if explictly enabled. Only run >4 primaries if extended if enabled. * Specify name of benchmark step on GH flow * Using perf-cto-base-image-ubuntu20.04-redis-7.4.0-tuned-latency on spot instances as well. * Fixed RedisJSON module path on benchmark setup. Enforcing ReJSON module to be present * Changing from 6 to 9 oss-standalone runners to achieve a time for full feedback < 30min * MODULE_FILE not working on Prepare ReJSON Module: using default location * Using redisbench-admin >= 0.11.3 due to multi-module issue * Using redisbench-admin >= 0.11.3 due to multi-module issue * Added missing --allowed-setups info for oss-standalone config * redisbench-admin >= 0.11.4 * Remove vecsim-ann-benchmarks_LOAD_1c_redisearch-hnsw_glove-200-angular_M-4.yml * Using redisbench-admin >= 0.11.5 due to ssh timeout issues on heavy benchmarks or heavy prunning at the end * Increasing concurrency of standalone benchmarks to reduce time to feedback * redisbench-admin >= 0.11.6. removed unstable test vecsim-ann-benchmarks_QUERY_1c_redisearch-hnsw_glove-200-angular_M-4 * redisbench-admin >= 0.11.7. running cluster tests faster and also ensuring we use a redisbench-admin with keepalive on ssh tunnels * Removed search-ftsb-10K-enwiki_abstract-hashes-term-withoutsuffix-trie from cluster tests due to keyspace error check * Removed search-ftsb-1M-enwiki_abstract-hashes-fulltext-simple-1word-query-non-sortable from cluster tests due to client error. created RediSearch/ftsb#97 * Not running *.rdb based benchmarks on cluster due to orphaned keys (redis/redis#9506) --------- Co-authored-by: fcostaoliveira <[email protected]>
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
* MOD-7596: Add mirroring support (#4937) * * initial commit * * Use RediSearch branch mirroring fork * * Code Review - Round #1 * MOD-7695: Decide Ubuntu Runner Using Variable (#4975) * * initial commit * * code review * Dvirdu_set_7.99.0_version_and_test_unstable (#4997) * 7.99.0 * redis unstable tests * CP single build path * Fix benchmark to use new build path (#5026) * Fix benchmark to use new build path * Take Raz's fix for benchmarks * fix default module path * make benchmark fail * fix path * fail external flow * remove fail fast and continue on error * addressing CR * Splitting the standalone work among 6 groups. Only profile if explictly enabled. Only run >4 primaries if extended if enabled. * Specify name of benchmark step on GH flow * Using perf-cto-base-image-ubuntu20.04-redis-7.4.0-tuned-latency on spot instances as well. * Fixed RedisJSON module path on benchmark setup. Enforcing ReJSON module to be present * Changing from 6 to 9 oss-standalone runners to achieve a time for full feedback < 30min * MODULE_FILE not working on Prepare ReJSON Module: using default location * Using redisbench-admin >= 0.11.3 due to multi-module issue * Using redisbench-admin >= 0.11.3 due to multi-module issue * Added missing --allowed-setups info for oss-standalone config * redisbench-admin >= 0.11.4 * Remove vecsim-ann-benchmarks_LOAD_1c_redisearch-hnsw_glove-200-angular_M-4.yml * Using redisbench-admin >= 0.11.5 due to ssh timeout issues on heavy benchmarks or heavy prunning at the end * Increasing concurrency of standalone benchmarks to reduce time to feedback * redisbench-admin >= 0.11.6. removed unstable test vecsim-ann-benchmarks_QUERY_1c_redisearch-hnsw_glove-200-angular_M-4 * redisbench-admin >= 0.11.7. running cluster tests faster and also ensuring we use a redisbench-admin with keepalive on ssh tunnels * Removed search-ftsb-10K-enwiki_abstract-hashes-term-withoutsuffix-trie from cluster tests due to keyspace error check * Removed search-ftsb-1M-enwiki_abstract-hashes-fulltext-simple-1word-query-non-sortable from cluster tests due to client error. created RediSearch/ftsb#97 * Not running *.rdb based benchmarks on cluster due to orphaned keys (redis/redis#9506) --------- Co-authored-by: fcostaoliveira <[email protected]> * rebase 8.0 --------- Co-authored-by: kei-nan <[email protected]> Co-authored-by: DvirDukhan <[email protected]> Co-authored-by: fcostaoliveira <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Fix broken benchmark flow (initially done by @raz-mon in #5018) + not using
COORD=0in benchmarks after removing this build option in #4935 + failing CI flow if a benchmark is failing, rather than failing silently as we did.Mark if applicable