Skip to content

MOD-7863: Add HPEXPIRETIME Mock Support#5025

Merged
kei-nan merged 2 commits intomasterfrom
master_jk_add_expiration_mock
Sep 16, 2024
Merged

MOD-7863: Add HPEXPIRETIME Mock Support#5025
kei-nan merged 2 commits intomasterfrom
master_jk_add_expiration_mock

Conversation

@kei-nan
Copy link
Collaborator

@kei-nan kei-nan commented Sep 16, 2024

Add minimal mock support for HPEXPIRETIME

A clear and concise description of what the PR is solving, including:

  1. We get an error in our cpp tests about HPEXPIRETIME error
  2. Add HPEXPIRETIME mock support
  3. Getting rid of the error in our tests

Which issues this PR fixes
2. MOD-7863

Main objects this PR modified

  1. Tests

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@kei-nan kei-nan requested a review from raz-mon September 16, 2024 08:02
@kei-nan kei-nan self-assigned this Sep 16, 2024
@kei-nan kei-nan marked this pull request as ready for review September 16, 2024 08:26
raz-mon
raz-mon previously approved these changes Sep 16, 2024
Copy link
Collaborator

@raz-mon raz-mon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (4a67a87) to head (fb8768a).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5025      +/-   ##
==========================================
+ Coverage   86.18%   86.30%   +0.12%     
==========================================
  Files         193      190       -3     
  Lines       34704    34593     -111     
==========================================
- Hits        29908    29855      -53     
+ Misses       4796     4738      -58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kei-nan kei-nan added this pull request to the merge queue Sep 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 16, 2024
@kei-nan kei-nan added this pull request to the merge queue Sep 16, 2024
Merged via the queue into master with commit cdc39c4 Sep 16, 2024
@kei-nan kei-nan deleted the master_jk_add_expiration_mock branch September 16, 2024 12:20
@github-actions
Copy link

Backport failed for 2.10, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.10
git worktree add -d .worktree/backport-5025-to-2.10 origin/2.10
cd .worktree/backport-5025-to-2.10
git switch --create backport-5025-to-2.10
git cherry-pick -x cdc39c440fe2c3fa3b071b14d6bb533c5fb94335

kei-nan added a commit that referenced this pull request Sep 16, 2024
* * add a mock for HPEXPIRETIME

* * Code Review - use ENOTSUP

(cherry picked from commit cdc39c4)
kei-nan added a commit that referenced this pull request Sep 16, 2024
* * add a mock for HPEXPIRETIME

* * Code Review - use ENOTSUP

(cherry picked from commit cdc39c4)
github-merge-queue bot pushed a commit that referenced this pull request Sep 24, 2024
MOD-7863: Add HPEXPIRETIME Mock Support (#5025)

* * add a mock for HPEXPIRETIME

* * Code Review - use ENOTSUP

(cherry picked from commit cdc39c4)
kei-nan added a commit that referenced this pull request Sep 25, 2024
* * add a mock for HPEXPIRETIME

* * Code Review - use ENOTSUP

(cherry picked from commit cdc39c4)
github-merge-queue bot pushed a commit that referenced this pull request Oct 7, 2024
MOD-7863: Add HPEXPIRETIME Mock Support (#5025)

* * add a mock for HPEXPIRETIME

* * Code Review - use ENOTSUP

(cherry picked from commit cdc39c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants