Dvirdu_set_7.99.0_version_and_test_unstable#4997
Merged
DvirDukhan merged 2 commits into8.0from Sep 11, 2024
Merged
Conversation
GuyAv46
approved these changes
Sep 5, 2024
Collaborator
GuyAv46
left a comment
GuyAv46
left a comment
There was a problem hiding this comment.
If we don’t need the tag we can skip this job in both flows
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 8.0 #4997 +/- ##
======================================
Coverage ? 86.13%
======================================
Files ? 192
Lines ? 34416
Branches ? 0
======================================
Hits ? 29645
Misses ? 4771
Partials ? 0 ☔ View full report in Codecov by Sentry. |
added 2 commits
September 10, 2024 22:00
DvirDukhan
force-pushed
the
dvirdu_set_7.99.0_version_and_test_unstable
branch
from
767c3c9 to
0cfe81f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
oshadmi
approved these changes
Sep 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
kei-nan
pushed a commit
that referenced
this pull request
Sep 24, 2024
* 7.99.0 * redis unstable tests
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
* MOD-7596: Add mirroring support (#4937) * * initial commit * * Use RediSearch branch mirroring fork * * Code Review - Round #1 * MOD-7695: Decide Ubuntu Runner Using Variable (#4975) * * initial commit * * code review * Dvirdu_set_7.99.0_version_and_test_unstable (#4997) * 7.99.0 * redis unstable tests * CP single build path * Fix benchmark to use new build path (#5026) * Fix benchmark to use new build path * Take Raz's fix for benchmarks * fix default module path * make benchmark fail * fix path * fail external flow * remove fail fast and continue on error * addressing CR * Splitting the standalone work among 6 groups. Only profile if explictly enabled. Only run >4 primaries if extended if enabled. * Specify name of benchmark step on GH flow * Using perf-cto-base-image-ubuntu20.04-redis-7.4.0-tuned-latency on spot instances as well. * Fixed RedisJSON module path on benchmark setup. Enforcing ReJSON module to be present * Changing from 6 to 9 oss-standalone runners to achieve a time for full feedback < 30min * MODULE_FILE not working on Prepare ReJSON Module: using default location * Using redisbench-admin >= 0.11.3 due to multi-module issue * Using redisbench-admin >= 0.11.3 due to multi-module issue * Added missing --allowed-setups info for oss-standalone config * redisbench-admin >= 0.11.4 * Remove vecsim-ann-benchmarks_LOAD_1c_redisearch-hnsw_glove-200-angular_M-4.yml * Using redisbench-admin >= 0.11.5 due to ssh timeout issues on heavy benchmarks or heavy prunning at the end * Increasing concurrency of standalone benchmarks to reduce time to feedback * redisbench-admin >= 0.11.6. removed unstable test vecsim-ann-benchmarks_QUERY_1c_redisearch-hnsw_glove-200-angular_M-4 * redisbench-admin >= 0.11.7. running cluster tests faster and also ensuring we use a redisbench-admin with keepalive on ssh tunnels * Removed search-ftsb-10K-enwiki_abstract-hashes-term-withoutsuffix-trie from cluster tests due to keyspace error check * Removed search-ftsb-1M-enwiki_abstract-hashes-fulltext-simple-1word-query-non-sortable from cluster tests due to client error. created RediSearch/ftsb#97 * Not running *.rdb based benchmarks on cluster due to orphaned keys (redis/redis#9506) --------- Co-authored-by: fcostaoliveira <[email protected]> * rebase 8.0 --------- Co-authored-by: kei-nan <[email protected]> Co-authored-by: DvirDukhan <[email protected]> Co-authored-by: fcostaoliveira <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
A clear and concise description of what the PR is solving, including:
Which issues this PR fixes
Main objects this PR modified
Mark if applicable