Conversation
WIP - clean makefile, move pack
wip: resolve conflicts, fix tests, libuv?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4935 +/- ##
==========================================
+ Coverage 86.18% 86.30% +0.12%
==========================================
Files 193 190 -3
Lines 34704 34593 -111
==========================================
- Hits 29908 29856 -52
+ Misses 4796 4737 -59 ☔ View full report in Codecov by Sentry. |
DvirDukhan
reviewed
Aug 22, 2024
DvirDukhan
left a comment
DvirDukhan
left a comment
There was a problem hiding this comment.
Nice!
More questions than comments
GuyAv46
reviewed
Sep 15, 2024
GuyAv46
previously approved these changes
Sep 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
GuyAv46
approved these changes
Sep 16, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.0
git worktree add -d .worktree/backport-4935-to-8.0 origin/8.0
cd .worktree/backport-4935-to-8.0
git switch --create backport-4935-to-8.0
git cherry-pick -x ba07994f5e5a991f93e27df556e30e9a2de40b95 |
This was referenced Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Complete the unified build for the module with the coordinator's component which is now an integral part of the module. This includes:
RS_COORDINTORbuild flag (which is now always true).LITEflavor - it is still possible to build an artifact under the namesearchlightfor backward compatibility, but the behavior will be the same as the non-light module (that is, the coordinator will take place and start lazily in a clustered environment).coord/module.cfile into the module'smodule.c(module's entry point whereRedisModule_OnLoadfunction should be) and resolve dependencies (link the entire module against hiredis/sds.h rather than rmutil/sds.h, and let the CPP tests use it but wrapping it withextern C).cmakelists.txtfile in the project root dir be the single entry point from which the modules (and unit test) artifacts are built (having thecmakelists.txtundercoorda subdirectory only, not an entry point as it was).packdir and rename them according to their purpose (ce, lite, enterprise)RSBuildTypeenum andbuild-infodir, and useIsEnterprise()call in runtime to determine the cluster build type instead.Mark if applicable