Conversation
upgrade gcc where possible
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4853 +/- ##
==========================================
- Coverage 86.08% 86.07% -0.02%
==========================================
Files 190 190
Lines 33877 33879 +2
==========================================
- Hits 29164 29160 -4
- Misses 4713 4719 +6 ☔ View full report in Codecov by Sentry. |
alonre24
approved these changes
Jul 9, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
* TODO: REVERT VECSIM POINTER!!!! upgrade gcc where possible * add sudo to update-alternatives * restore vecsim * restore (cherry picked from commit c23e567)
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
[MOD-7341] Upgrade gcc (#4853) * TODO: REVERT VECSIM POINTER!!!! upgrade gcc where possible * add sudo to update-alternatives * restore vecsim * restore (cherry picked from commit c23e567) Co-authored-by: meiravgri <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
[MOD-7341] Upgrade gcc (#4853) * TODO: REVERT VECSIM POINTER!!!! upgrade gcc where possible * add sudo to update-alternatives * restore vecsim * restore (cherry picked from commit c23e567) Co-authored-by: meiravgri <[email protected]>
kei-nan
pushed a commit
that referenced
this pull request
Sep 8, 2024
kei-nan
pushed a commit
that referenced
this pull request
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install gcc12.3+ on supporting OS to enable building with
AVX512_FP16optimization in vecsim.Mark if applicable