MOD-7543 purge readies from sanitizer flow#4726
Conversation
DvirDukhan
force-pushed
the
dvirdu_santizer
branch
from
83344a3 to
4eed00c
Compare
DvirDukhan
force-pushed
the
dvirdu_santizer
branch
from
6f1e992 to
5176130
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4726 +/- ##
==========================================
- Coverage 86.50% 86.50% -0.01%
==========================================
Files 195 195
Lines 34818 34818
==========================================
- Hits 30121 30120 -1
- Misses 4697 4698 +1 ☔ View full report in Codecov by Sentry. |
.github/workflows/flow-sanitizer.yml
Outdated
| type: string | ||
| required: true | ||
| get-redis: | ||
| type: string |
There was a problem hiding this comment.
This new parameter is not passed to the next workflow
.install/install_llvm.sh
Outdated
| if [[ $OS_TYPE == Darwin ]]; then | ||
| brew install llvm@$VERSION | ||
| else | ||
| $MODE apt install lsb-release wget software-properties-common gnupg |
There was a problem hiding this comment.
If we use apt is it working on all Linux based OSs?
There was a problem hiding this comment.
yes, let's start here, with the common OSs to devs, and see if we need to add support to other OSs as well
|
IMO CI infrastructure should be aligned and up-to-date across all maintained branches (master and versions). This makes maintaining the CI much simpler as we practically have a single infra, and if something breaks we only need a single fix (with CPs) |
.github/workflows/flow-sanitizer.yml
Outdated
| san: addr | ||
| san: address | ||
| env: ubuntu-latest | ||
| rejson: 0 |
There was a problem hiding this comment.
Still needed? json sanitizer hiccup solved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
| run: | | ||
| ${{ steps.mode.outputs.mode }} SANITIZER=${{ inputs.san }} BUILD_TLS=yes make install |
There was a problem hiding this comment.
| run: | | |
| ${{ steps.mode.outputs.mode }} SANITIZER=${{ inputs.san }} BUILD_TLS=yes make install | |
| env: | |
| BUILD_TLS: yes | |
| SANITIZER: ${{ input.san }} | |
| run: ${{ steps.mode.outputs.mode }} make install |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-4726-to-2.8 origin/2.8
cd .worktree/backport-4726-to-2.8
git switch --create backport-4726-to-2.8
git cherry-pick -x 29d0b784048d5f8c00a6b7792664a8d5c87ba840 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.6
git worktree add -d .worktree/backport-4726-to-2.6 origin/2.6
cd .worktree/backport-4726-to-2.6
git switch --create backport-4726-to-2.6
git cherry-pick -x 29d0b784048d5f8c00a6b7792664a8d5c87ba840 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-4726-to-2.10 origin/2.10
cd .worktree/backport-4726-to-2.10
git switch --create backport-4726-to-2.10
git cherry-pick -x 29d0b784048d5f8c00a6b7792664a8d5c87ba840 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 8.0
git worktree add -d .worktree/backport-4726-to-8.0 origin/8.0
cd .worktree/backport-4726-to-8.0
git switch --create backport-4726-to-8.0
git cherry-pick -x 29d0b784048d5f8c00a6b7792664a8d5c87ba840 |
6 participants
Describe the changes in the pull request
This PR purges Readies from the sanitizer flow, allowing for an easier, less intrusive workflow by using the standard docker and dependency toolchain.
This PR unifies the flows for all test flows (test, coverage, sanitizer) to use
task-test.yml.This PR moves the llvm and rust installations to our common
.installfolder, where they should be, and removes them frombuild-rejsonscriptAs a temporary workaround, this PR also disables sanitizer with JSON tests, until a fix is submitted to RedisJSON repo
Also, we link statically to libstdc++ when we run sanitizer, since otherwise we crash in geometry tests otherwise. This is fine as long as we test sanitizer against redis 7.4. When we move to test against redis 8, we should link libstdc++ dynamically (as we do from now on).
Which issues this PR fixes
MOD-7453
Main objects this PR modified
task-test.yml
build-rejson