Skip to content

[2.10] MOD-5977 MOD-5866: Fix inverted index memory counting (#4218)#4668

Merged
nafraf merged 1 commit into2.10from
nafraf_backport-4218-to-2.10
May 24, 2024
Merged

[2.10] MOD-5977 MOD-5866: Fix inverted index memory counting (#4218)#4668
nafraf merged 1 commit into2.10from
nafraf_backport-4218-to-2.10

Conversation

@nafraf
Copy link
Collaborator

@nafraf nafraf commented May 23, 2024

Description

Backport of #4218 to 2.10.
(cherry picked from commit 959ed1a)

Which issues this PR fixes

  1. MOD-5977
  2. MOD-5866

(done through MOD-6515)

---------
Co-authored-by: Omer Shadmi <[email protected]>
(cherry picked from commit 959ed1a)
@nafraf nafraf marked this pull request as ready for review May 23, 2024 16:21
@nafraf nafraf requested a review from oshadmi May 23, 2024 16:36
@codecov
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 86.14%. Comparing base (b5b52b4) to head (f2b4564).

Files Patch % Lines
src/qint.c 69.23% 4 Missing ⚠️
src/fork_gc.c 88.88% 2 Missing ⚠️
src/inverted_index.c 87.50% 2 Missing ⚠️
src/numeric_index.c 88.88% 2 Missing ⚠️
src/redis_index.c 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.10    #4668      +/-   ##
==========================================
+ Coverage   86.08%   86.14%   +0.06%     
==========================================
  Files         190      190              
  Lines       34478    34490      +12     
==========================================
+ Hits        29679    29712      +33     
+ Misses       4799     4778      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nafraf nafraf added this pull request to the merge queue May 24, 2024
Merged via the queue into 2.10 with commit e417057 May 24, 2024
@nafraf nafraf deleted the nafraf_backport-4218-to-2.10 branch May 24, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants