Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4629 +/- ##
==========================================
- Coverage 85.98% 85.97% -0.01%
==========================================
Files 190 190
Lines 34517 34515 -2
==========================================
- Hits 29678 29673 -5
- Misses 4839 4842 +3 ☔ View full report in Codecov by Sentry. |
GuyAv46
approved these changes
May 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
FT.DROPINDEXwithDDargument is supposed to delete the keys that are indexed by the dropped index. TheDELcommand was not being replicated when deleting keys and therefore was not being replicated to other sites of the CRDB (relevant for Redis Enterprise with Active-Active - test passed thanks to @TomerHekmati 🙏🏼)The fix is to not avoid replicating the command allowing the key to be deleted on other sites as well.
Test case
Create an index and create a key on primary site, see the key is replicated, call
FT.DROPINDEXwithDDon primary, see the key is deleted on primary and on replica.Which issues this PR fixes
Mark if applicable