MOD-6846: Replace average cycle time with total time in Redis INFO#4590
Merged
MOD-6846: Replace average cycle time with total time in Redis INFO#4590
INFO#4590Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4590 +/- ##
==========================================
- Coverage 85.66% 85.65% -0.01%
==========================================
Files 188 188
Lines 33013 33009 -4
==========================================
- Hits 28279 28273 -6
- Misses 4734 4736 +2 ☔ View full report in Codecov by Sentry. |
oshadmi
previously approved these changes
Apr 11, 2024
oshadmi
approved these changes
Apr 11, 2024
raz-mon
changed the title
INFOINFO
|
Successfully created backport PR for |
oshadmi
pushed a commit
that referenced
this pull request
Dec 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
* MOD-6846: Enhance INFO response (#4561) (cherry picked from commit 73e717f) (cherry picked from commit 71a4af2) (cherry picked from commit 6a2c6fa) * MOD-6846: Replace average cycle time with total time in Redis `INFO` (#4590) * Replace average cycle time with total time * Change INFO field name to correspond to FT.INFO field name (cherry picked from commit 71a4af2) * Fix failure with redis 5.0.5 output * Add metrics of min and max memory consumption of indexes - [MOD-7584] (#5143) (cherry picked from commit 094318f) * Code review fix * Try fix dnf install conflicting requests --------- Co-authored-by: Raz Monsonego <[email protected]> Co-authored-by: redisearch-backport-pull-request[bot] <182669528+redisearch-backport-pull-request[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes in the pull request
Replaces the current
average_cycle_time_msfield in theINFOresponse tototal_ms_run, so that the aggregation of the field in the DMC will be possible. The user can compute the average cycle run if he wants.Mark if applicable