Skip to content

MOD-6846: Enhance INFO response#4561

Merged
raz-mon merged 13 commits intomasterfrom
razmon-info
Apr 2, 2024
Merged

MOD-6846: Enhance INFO response#4561
raz-mon merged 13 commits intomasterfrom
razmon-info

Conversation

@raz-mon
Copy link
Collaborator

@raz-mon raz-mon commented Mar 28, 2024

Describe the changes in the pull request

In this PR, we enhance the response for the INFO command to return the following fields (in addition to the existing ones):

  • used_memory_indexes
  • used_memory_indexes_human
  • total_indexing_time
  • global_idle
  • global_total
  • bytes_collected
  • total_cycles
  • average_cycle_time_ms

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@codecov
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 97.95918% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.63%. Comparing base (d4be78a) to head (dab96fc).
Report is 2 commits behind head on master.

Files Patch % Lines
src/redisearch_api.c 95.65% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4561   +/-   ##
=======================================
  Coverage   85.62%   85.63%           
=======================================
  Files         188      188           
  Lines       32954    33003   +49     
=======================================
+ Hits        28217    28262   +45     
- Misses       4737     4741    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

oshadmi
oshadmi previously approved these changes Mar 31, 2024
Copy link
Collaborator

@oshadmi oshadmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 😎

GuyAv46
GuyAv46 previously approved these changes Apr 1, 2024
@raz-mon raz-mon added this pull request to the merge queue Apr 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 1, 2024
oshadmi
oshadmi previously approved these changes Apr 1, 2024
@raz-mon raz-mon enabled auto-merge April 1, 2024 12:47
@raz-mon raz-mon added this pull request to the merge queue Apr 2, 2024
Merged via the queue into master with commit 73e717f Apr 2, 2024
@raz-mon raz-mon deleted the razmon-info branch April 2, 2024 08:53
@github-actions
Copy link

github-actions bot commented Apr 2, 2024

Successfully created backport PR for 2.10:

oshadmi pushed a commit that referenced this pull request Dec 17, 2024
(cherry picked from commit 73e717f)

(cherry picked from commit 71a4af2)

(cherry picked from commit 6a2c6fa)
github-merge-queue bot pushed a commit that referenced this pull request Dec 19, 2024
* MOD-6846: Enhance INFO response (#4561)

(cherry picked from commit 73e717f)

(cherry picked from commit 71a4af2)

(cherry picked from commit 6a2c6fa)

* MOD-6846: Replace average cycle time with total time in Redis `INFO` (#4590)

* Replace average cycle time with total time

* Change INFO field name to correspond to FT.INFO field name

(cherry picked from commit 71a4af2)

* Fix failure with redis 5.0.5 output

* Add metrics of min and max memory consumption of indexes - [MOD-7584] (#5143)

(cherry picked from commit 094318f)

* Code review fix

* Try fix dnf install conflicting requests

---------

Co-authored-by: Raz Monsonego <[email protected]>
Co-authored-by: redisearch-backport-pull-request[bot] <182669528+redisearch-backport-pull-request[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants