Skip to content

Fork GC cleanup#4243

Merged
GuyAv46 merged 2 commits intomasterfrom
guyav-fork_gc_cleanup
Dec 20, 2023
Merged

Fork GC cleanup#4243
GuyAv46 merged 2 commits intomasterfrom
guyav-fork_gc_cleanup

Conversation

@GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Dec 20, 2023

Describe the changes in the pull request

some dead code cleanup

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@GuyAv46 GuyAv46 requested a review from meiravgri December 20, 2023 12:59
@codecov
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.66%. Comparing base (7b06223) to head (efd29c8).
Report is 341 commits behind head on master.

Files with missing lines Patch % Lines
src/fork_gc.c 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4243      +/-   ##
==========================================
+ Coverage   83.64%   83.66%   +0.01%     
==========================================
  Files         191      191              
  Lines       33526    33510      -16     
==========================================
- Hits        28043    28035       -8     
+ Misses       5483     5475       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 force-pushed the guyav-fork_gc_cleanup branch from 09f677a to efd29c8 Compare December 20, 2023 14:19
@GuyAv46 GuyAv46 enabled auto-merge December 20, 2023 14:22
@GuyAv46 GuyAv46 added this pull request to the merge queue Dec 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2023
@GuyAv46 GuyAv46 added this pull request to the merge queue Dec 20, 2023
@GuyAv46 GuyAv46 removed this pull request from the merge queue due to a manual request Dec 20, 2023
@GuyAv46 GuyAv46 added this pull request to the merge queue Dec 20, 2023
@GuyAv46 GuyAv46 removed this pull request from the merge queue due to a manual request Dec 20, 2023
@GuyAv46 GuyAv46 added this pull request to the merge queue Dec 20, 2023
Merged via the queue into master with commit c98fefa Dec 20, 2023
@GuyAv46 GuyAv46 deleted the guyav-fork_gc_cleanup branch December 20, 2023 23:55
raz-mon pushed a commit that referenced this pull request Mar 6, 2024
* some dead code cleanup

* added fork API to the mock
@kei-nan
Copy link
Collaborator

kei-nan commented Jan 14, 2025

/backport

@redisearch-backport-pull-request
Copy link
Contributor

Backport failed for 2.8, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.8
git worktree add -d .worktree/backport-4243-to-2.8 origin/2.8
cd .worktree/backport-4243-to-2.8
git switch --create backport-4243-to-2.8
git cherry-pick -x c98fefa52ecafeb58517d42627fd7d629613b2c6

@redisearch-backport-pull-request
Copy link
Contributor

Backport failed for 2.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.6
git worktree add -d .worktree/backport-4243-to-2.6 origin/2.6
cd .worktree/backport-4243-to-2.6
git switch --create backport-4243-to-2.6
git cherry-pick -x c98fefa52ecafeb58517d42627fd7d629613b2c6

kei-nan pushed a commit that referenced this pull request Jan 14, 2025
* some dead code cleanup

* added fork API to the mock

(cherry picked from commit c98fefa)
kei-nan pushed a commit that referenced this pull request Jan 14, 2025
* some dead code cleanup

* added fork API to the mock

(cherry picked from commit c98fefa)
This was referenced Jan 14, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 15, 2025
Fork GC cleanup (#4243)

* some dead code cleanup

* added fork API to the mock

(cherry picked from commit c98fefa)

Co-authored-by: GuyAv46 <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jan 20, 2025
* Fork GC cleanup (#4243)

* some dead code cleanup

* added fork API to the mock

(cherry picked from commit c98fefa)

* * fix compilation

* * Code Review Comments

---------

Co-authored-by: GuyAv46 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants