minor fixes by merl-dev · Pull Request #2 · RediSearch/RediSearch

merl-dev · 2016-06-22T10:16:52Z

I found a few minor issues that prevented compilation. Ran a few tests on the compiled module and seems to be fine.

dvirsky · 2016-06-22T10:24:11Z

those are really odd that they got in, probably during yesterday's commit of indentation fixes. anyway thanks, I'm merging these.

merl-dev · 2016-06-22T10:27:45Z

txs, where are you located?

dvirsky · 2016-06-22T10:28:46Z

Tel Aviv. You?

merl-dev · 2016-06-22T10:30:22Z

same, cool!

dvirsky · 2016-06-22T10:33:11Z

glad you're interested in this. BTW we're hosting a meetup about modules in a few weeks, I hope you'll attend. I think it's going to be in 18/7.

merl-dev · 2016-06-22T10:37:48Z

sounds good. I have been working with Redis in production for about 2 years, now on sabbatical devoted almost exclusively to Redis. I am a Julia coder, right now undertaking massive refak of the Redis.jl package and will be issuing a RedisModules.jl soon after to interface with all these very cool modules, plus 2 modules that I am presently working on. My focus is streaming/online stats for online media and finance + nonstationarity TS modelling. I believe this could be a good contender in what is becoming a very competitive environment.
Will definitely attend the meetup.

merl-dev · 2016-06-22T10:41:25Z

you have a redislabs email?

dvirsky · 2016-06-22T10:44:37Z

yep, dvir at ...

merl-dev · 2016-06-22T10:47:54Z

sent a linked in invite, Yaakov Borstein

…obal Config (#5137) * * move cursor limitation per index to be a configuration parameter * solve a bug where the coordinator would stop reading from internal cursors * * remove int return type for iterate callback functions, since their return value is ignored and has no real meaning. * * Code Review - Round #1 * * Code Review - Round #1, missing file change * * fix crash in testAggregate.py * * Code Review - Round #2 * * replace comma with a period * * if we somehow ended up with a closed channel, free the reply * Update src/config.c Co-authored-by: GuyAv46 <[email protected]> * Update src/cursor.c Co-authored-by: Omer Shadmi <[email protected]> * - fix channel test * - add logging for the broadcasting failure flow * - changed broadcast failure to be verbose instead of warning * Update tests/pytests/test_cursors.py Co-authored-by: Omer Shadmi <[email protected]> --------- Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: Omer Shadmi <[email protected]>

…obal Config (#5137) * * move cursor limitation per index to be a configuration parameter * solve a bug where the coordinator would stop reading from internal cursors * * remove int return type for iterate callback functions, since their return value is ignored and has no real meaning. * * Code Review - Round #1 * * Code Review - Round #1, missing file change * * fix crash in testAggregate.py * * Code Review - Round #2 * * replace comma with a period * * if we somehow ended up with a closed channel, free the reply * Update src/config.c Co-authored-by: GuyAv46 <[email protected]> * Update src/cursor.c Co-authored-by: Omer Shadmi <[email protected]> * - fix channel test * - add logging for the broadcasting failure flow * - changed broadcast failure to be verbose instead of warning * Update tests/pytests/test_cursors.py Co-authored-by: Omer Shadmi <[email protected]> --------- Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: Omer Shadmi <[email protected]> (cherry picked from commit 602fe76)

…ugh Global Config (#5165) MOD-8009: Allow Users To Configure Cursor Index Limitation Through Global Config (#5137) * * move cursor limitation per index to be a configuration parameter * solve a bug where the coordinator would stop reading from internal cursors * * remove int return type for iterate callback functions, since their return value is ignored and has no real meaning. * * Code Review - Round #1 * * Code Review - Round #1, missing file change * * fix crash in testAggregate.py * * Code Review - Round #2 * * replace comma with a period * * if we somehow ended up with a closed channel, free the reply * Update src/config.c Co-authored-by: GuyAv46 <[email protected]> * Update src/cursor.c Co-authored-by: Omer Shadmi <[email protected]> * - fix channel test * - add logging for the broadcasting failure flow * - changed broadcast failure to be verbose instead of warning * Update tests/pytests/test_cursors.py Co-authored-by: Omer Shadmi <[email protected]> --------- Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: Omer Shadmi <[email protected]> (cherry picked from commit 602fe76) Co-authored-by: kei-nan <[email protected]>

…ugh Global Config (#5167) * MOD-8009: Allow Users To Configure Cursor Index Limitation Through Global Config (#5137) * * move cursor limitation per index to be a configuration parameter * solve a bug where the coordinator would stop reading from internal cursors * * remove int return type for iterate callback functions, since their return value is ignored and has no real meaning. * * Code Review - Round #1 * * Code Review - Round #1, missing file change * * fix crash in testAggregate.py * * Code Review - Round #2 * * replace comma with a period * * if we somehow ended up with a closed channel, free the reply * Update src/config.c Co-authored-by: GuyAv46 <[email protected]> * Update src/cursor.c Co-authored-by: Omer Shadmi <[email protected]> * - fix channel test * - add logging for the broadcasting failure flow * - changed broadcast failure to be verbose instead of warning * Update tests/pytests/test_cursors.py Co-authored-by: Omer Shadmi <[email protected]> --------- Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: Omer Shadmi <[email protected]> (cherry picked from commit 602fe76) * * fix config test

…ough Global Config (#5166) MOD-8009: Allow Users To Configure Cursor Index Limitation Through Global Config (#5137) * * move cursor limitation per index to be a configuration parameter * solve a bug where the coordinator would stop reading from internal cursors * * remove int return type for iterate callback functions, since their return value is ignored and has no real meaning. * * Code Review - Round #1 * * Code Review - Round #1, missing file change * * fix crash in testAggregate.py * * Code Review - Round #2 * * replace comma with a period * * if we somehow ended up with a closed channel, free the reply * Update src/config.c Co-authored-by: GuyAv46 <[email protected]> * Update src/cursor.c Co-authored-by: Omer Shadmi <[email protected]> * - fix channel test * - add logging for the broadcasting failure flow * - changed broadcast failure to be verbose instead of warning * Update tests/pytests/test_cursors.py Co-authored-by: Omer Shadmi <[email protected]> --------- Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: Omer Shadmi <[email protected]> (cherry picked from commit 602fe76)

…ugh Global Config (#5168) * MOD-8009: Allow Users To Configure Cursor Index Limitation Through Global Config (#5137) * * move cursor limitation per index to be a configuration parameter * solve a bug where the coordinator would stop reading from internal cursors * * remove int return type for iterate callback functions, since their return value is ignored and has no real meaning. * * Code Review - Round #1 * * Code Review - Round #1, missing file change * * fix crash in testAggregate.py * * Code Review - Round #2 * * replace comma with a period * * if we somehow ended up with a closed channel, free the reply * Update src/config.c Co-authored-by: GuyAv46 <[email protected]> * Update src/cursor.c Co-authored-by: Omer Shadmi <[email protected]> * - fix channel test * - add logging for the broadcasting failure flow * - changed broadcast failure to be verbose instead of warning * Update tests/pytests/test_cursors.py Co-authored-by: Omer Shadmi <[email protected]> --------- Co-authored-by: GuyAv46 <[email protected]> Co-authored-by: Omer Shadmi <[email protected]> (cherry picked from commit 602fe76) * * use RSGlobalConfig.indexCursorLimit * * apply missing cherry-pick changes * * fix netCursorCallback callback return type * * code review comments + test crash fix * * fix remaining code review comments

* MOD-7864: initial commit * * modify object obfuscate api * * compilation fixes * * fix tests * * add query node obfuscation test * * Code Review - Round #1 * * add field path obfuscation * update tests * * Code Review - Round #2 * * Code Review - Round #3 * * Code Review - Round #4 * * add MAX_UNIQUE_ID_TEXT_LENGTH_UPPER_BOUND, compute it based on sizeof t_uniqueId * * add copyright

* MOD-7864: initial commit * * modify object obfuscate api * * compilation fixes * * fix tests * * add query node obfuscation test * * Code Review - Round #1 * * add field path obfuscation * update tests * * Code Review - Round #2 * * Code Review - Round #3 * * Code Review - Round #4 * * add MAX_UNIQUE_ID_TEXT_LENGTH_UPPER_BOUND, compute it based on sizeof t_uniqueId * * add copyright (cherry picked from commit 9235579)

MOD-7864: Obfuscation API (#5060) * MOD-7864: initial commit * * modify object obfuscate api * * compilation fixes * * fix tests * * add query node obfuscation test * * Code Review - Round #1 * * add field path obfuscation * update tests * * Code Review - Round #2 * * Code Review - Round #3 * * Code Review - Round #4 * * add MAX_UNIQUE_ID_TEXT_LENGTH_UPPER_BOUND, compute it based on sizeof t_uniqueId * * add copyright (cherry picked from commit 9235579) Co-authored-by: kei-nan <[email protected]>

…ing them as valid results (#4858) * * initial commit * * fix missing case in test_expire.py * * fix coord compilation * * fix doc info test * * try and fix some of the tests * * release iterator * * do not set expiration time in the context of the coordinator since it doesn't have an index spec * * support c++ tests that do not provide spec for iterators * * no point in passing timestamp in coordinator flow * * redis 7.4 version in ci is actually 7.3, for codecov we need our tests to run * * reduce max memory from + 200000 to 150000 * * fix test * * cleanup code * * Code Review: Round #1 * * Add geoshape tests, only pass index instead of pointer to filter ctx * * Add vector test * * Code Review - Round #2 * * try and fix tests * * Code Review - Round #3 * * Fix Sanitizer Build * * Code Review - Round #4 * * Minor change in debug command SET_MONITOR_EXPIRATION * * Code Review - Round #5 * * fix tests * * Code Review - Round #6 * * fix crash * * fix test * * improve field mask translation time * fix compilation * fix compilation error * handle field mask of 64 bit * * Code Review - Round #7 * * fix opening of key edge cases * * free fieldIdToIndex array * Code Review - Round #9 * * fix rebase conflicts * support wild card reader filtering * * mac os: fallback to CLOCK_REALTIME if CLOCK_REALTIME_COARSE is not defined (cherry picked from commit 4a67a87)

…returning them as valid results (#5118) * MOD-7329: Determine if fields and documents are expired before returning them as valid results (#4858) * * initial commit * * fix missing case in test_expire.py * * fix coord compilation * * fix doc info test * * try and fix some of the tests * * release iterator * * do not set expiration time in the context of the coordinator since it doesn't have an index spec * * support c++ tests that do not provide spec for iterators * * no point in passing timestamp in coordinator flow * * redis 7.4 version in ci is actually 7.3, for codecov we need our tests to run * * reduce max memory from + 200000 to 150000 * * fix test * * cleanup code * * Code Review: Round #1 * * Add geoshape tests, only pass index instead of pointer to filter ctx * * Add vector test * * Code Review - Round #2 * * try and fix tests * * Code Review - Round #3 * * Fix Sanitizer Build * * Code Review - Round #4 * * Minor change in debug command SET_MONITOR_EXPIRATION * * Code Review - Round #5 * * fix tests * * Code Review - Round #6 * * fix crash * * fix test * * improve field mask translation time * fix compilation * fix compilation error * handle field mask of 64 bit * * Code Review - Round #7 * * fix opening of key edge cases * * free fieldIdToIndex array * Code Review - Round #9 * * fix rebase conflicts * support wild card reader filtering * * mac os: fallback to CLOCK_REALTIME if CLOCK_REALTIME_COARSE is not defined (cherry picked from commit 4a67a87) * MOD-7979: Protect Against RS_FIELDMASK_ALL Mask Edge Case (#5128) * * check mask edge case * * Code Review - Round #1 (cherry picked from commit 2c037bc) * [8.0] MOD-7976: Fix HFE Regression (#5336) MOD-7976: Fix HFE Regression (#5318) * * use new expiration API to avoid regression issues with HFE support when expiration isn't being used * * update sdk to get new hash field expiration API * * set monitorFieldExpiration default based on the existence of `RedisModule_HashFieldMinExpire` * * skip field expiration tests if below 8.0 API * * Code Review Comments * Prevent turning on the monitorFieldExpiration if the API does not exist * * move to run against redis 8.0 (cherry picked from commit bebdeb7) * * rebase fixes * * add REDISMODULE_OPEN_KEY_NOEFFECTS to OpenKey when loading json document * * fix for test_debug_commands.py

* MOD-7864: initial commit * * modify object obfuscate api * * compilation fixes * * fix tests * * add query node obfuscation test * * Code Review - Round #1 * * add field path obfuscation * update tests * * Code Review - Round #2 * * Code Review - Round #3 * * Code Review - Round #4 * * add MAX_UNIQUE_ID_TEXT_LENGTH_UPPER_BOUND, compute it based on sizeof t_uniqueId * * add copyright (cherry picked from commit 9235579)

MOD-7864: Obfuscation API (#5060) * MOD-7864: initial commit * * modify object obfuscate api * * compilation fixes * * fix tests * * add query node obfuscation test * * Code Review - Round #1 * * add field path obfuscation * update tests * * Code Review - Round #2 * * Code Review - Round #3 * * Code Review - Round #4 * * add MAX_UNIQUE_ID_TEXT_LENGTH_UPPER_BOUND, compute it based on sizeof t_uniqueId * * add copyright (cherry picked from commit 9235579)

* MOD-7864: Obfuscation API (#5060) * MOD-7864: initial commit * * modify object obfuscate api * * compilation fixes * * fix tests * * add query node obfuscation test * * Code Review - Round #1 * * add field path obfuscation * update tests * * Code Review - Round #2 * * Code Review - Round #3 * * Code Review - Round #4 * * add MAX_UNIQUE_ID_TEXT_LENGTH_UPPER_BOUND, compute it based on sizeof t_uniqueId * * add copyright (cherry picked from commit 9235579) * * fix compilation * * forward declare index spec in query_node.h * * fix test

* MOD-7864: Obfuscation API (#5060) * MOD-7864: initial commit * * modify object obfuscate api * * compilation fixes * * fix tests * * add query node obfuscation test * * Code Review - Round #1 * * add field path obfuscation * update tests * * Code Review - Round #2 * * Code Review - Round #3 * * Code Review - Round #4 * * add MAX_UNIQUE_ID_TEXT_LENGTH_UPPER_BOUND, compute it based on sizeof t_uniqueId * * add copyright (cherry picked from commit 9235579) * * fix compilation * * forward declare index spec in query_node.h * * compilation fix * * fix test

* cherry-pick and resolve conflicts (WIP) working currently build only wip: - tests - coord * running CI with pytest and unit tests (standalone) wip - coord * Changes to support coord build and pytest * fix enable assert, and mt build * Fix hiredis to include ssl, fix build for coverage , make sure COORD env var is respected * allow passing COORD=1 * align the bin output dir names with what is was * fix test flows * allow coord=1 * allow coord=1 FROM ENV VAR * fix MT_BUILD in coord and pass COORD var properly to pytests * pass COORD var properly #2 + use ./build for running pytests * build coord with san build extension module always * link statically to libstdc++ * Pass static-libstdc++ to linker * fix binary dirname for arm and build for apple * Pass QUICK config as build.sh requires * fox to support empty coord string * revert "quick=1" pass fix (will be handled in different PR) * Revert "Pass QUICK config as build.sh requires" This reverts commit 8c7b67c.

* Add numeric_range_tree crate (core data structure) * Address review feedback. * Address review feedback, round #2

minor fixes

8678714

dvirsky merged commit f29cedd into RediSearch:master Jun 22, 2016

salt4pommes mentioned this pull request Sep 12, 2017

Crash when using nonsense LIMIT #160

Closed

zanek mentioned this pull request Nov 16, 2018

FT.SUGGET with 3 parameters crashes Redis #539

Closed

joeirimpan mentioned this pull request Feb 4, 2019

FT.SPELLCHECK crashes when syntax error in query string #589

Closed

srikanthm-1 mentioned this pull request Feb 6, 2019

[docker redislabs/redisearch:1.4.0] container keeps crashing during startup #595

Closed

vlradstake mentioned this pull request Feb 14, 2019

FT.search with SORTYBY crashes redis server #603

Closed

dme-development mentioned this pull request Feb 21, 2019

Redis crash on FT.SEARCH (IR_GetCriteriaTester) #613

Closed

manishtoons mentioned this pull request Feb 22, 2019

Redis crashes unexpecteldy #617

Closed

mnunberg mentioned this pull request Apr 12, 2019

Query with FILTER crashes #654

Closed

wimdeboel mentioned this pull request May 23, 2019

Unexpected crash (on AggregateCommand ?) v1.4.5 #701

Open

tomgevaert mentioned this pull request May 27, 2019

Bug report 4.0.7 - Redisearch 1.4.8 #714

Closed

tomindo mentioned this pull request Jun 11, 2019

redis server crashed with ft.search #728

Closed

mmasouras mentioned this pull request Jun 24, 2019

FT.ADDHASH causes core-dump #736

Closed

bpress mentioned this pull request Jul 17, 2019

Redis crash in redisearch.so #769

Open

mnunberg mentioned this pull request Sep 3, 2019

Crash while inserting #888

Closed

dwedwick mentioned this pull request Sep 10, 2019

Redis 5.0.5 crashed by signal: 11 - using RediSearch #905

Closed

rafie added a commit that referenced this pull request Sep 26, 2019

Fixed from review #2

8dd3343

mmasouras mentioned this pull request Sep 26, 2019

RediSearch Crashes #918

Closed

rafie added a commit that referenced this pull request Oct 10, 2019

Added macOS build to CircleCI #2

109a0eb

dme-development mentioned this pull request Oct 14, 2019

RediSearch crash on v1.4.16 & also on v1.4.20 #947

Open

kei-nan added a commit that referenced this pull request Oct 31, 2024

* Code Review - Round #2

ebe6d3d

mjblackend mentioned this pull request Jan 16, 2025

[CRASH] RediSearch Crash after working for several hours, with Redis 7.2.0 crashed by signal: 11, si_code: 128 and Accessing address: (nil) #5517

Closed

alonre24 added a commit that referenced this pull request May 15, 2025

pass COORD var properly #2 + use ./build for running pytests

2f601ec

Itzikvaknin added a commit that referenced this pull request Oct 12, 2025

Try #2

2952749

LukeMathWalker added a commit that referenced this pull request Feb 9, 2026

Address review feedback, round #2

e09782e

github-merge-queue bot pushed a commit that referenced this pull request Feb 9, 2026

[MOD-13843] A Rust implementation of the numeric index (#8276)

c20a807

* Add numeric_range_tree crate (core data structure) * Address review feedback. * Address review feedback, round #2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

minor fixes#2

minor fixes#2
dvirsky merged 1 commit intoRediSearch:masterfrom
merl-dev:master

merl-dev commented Jun 22, 2016

Uh oh!

dvirsky commented Jun 22, 2016

Uh oh!

merl-dev commented Jun 22, 2016

Uh oh!

dvirsky commented Jun 22, 2016

Uh oh!

merl-dev commented Jun 22, 2016

Uh oh!

dvirsky commented Jun 22, 2016

Uh oh!

merl-dev commented Jun 22, 2016

Uh oh!

merl-dev commented Jun 22, 2016

Uh oh!

dvirsky commented Jun 22, 2016

Uh oh!

merl-dev commented Jun 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

merl-dev commented Jun 22, 2016

Uh oh!

dvirsky commented Jun 22, 2016

Uh oh!

merl-dev commented Jun 22, 2016

Uh oh!

dvirsky commented Jun 22, 2016

Uh oh!

merl-dev commented Jun 22, 2016

Uh oh!

dvirsky commented Jun 22, 2016

Uh oh!

merl-dev commented Jun 22, 2016

Uh oh!

merl-dev commented Jun 22, 2016

Uh oh!

dvirsky commented Jun 22, 2016

Uh oh!

merl-dev commented Jun 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants