Skip to content

fix(operators): force patch modules to not emit empty declarations#1018

Merged
kwonoj merged 1 commit intoReactiveX:masterfrom
robwormald:fix-add-declarations
Dec 10, 2015
Merged

fix(operators): force patch modules to not emit empty declarations#1018
kwonoj merged 1 commit intoReactiveX:masterfrom
robwormald:fix-add-declarations

Conversation

@robwormald
Copy link
Copy Markdown
Contributor

@robwormald robwormald commented Dec 10, 2015

closes #1010

@kwonoj
Copy link
Copy Markdown
Member

kwonoj commented Dec 10, 2015

Just curiosity, what happens if delete all `.../add/*/.d.ts' ?

@robwormald
Copy link
Copy Markdown
Contributor Author

robwormald commented Dec 10, 2015

That works, but only until we bump up to TS 1.8 and patch the operator definition in the 'add' module.

On Dec 9, 2015, at 4:39 PM, OJ Kwon [email protected] wrote:

Just curiosity, what happens if delete all `.../add/*/.d.ts' ?

—
Reply to this email directly or view it on GitHub #1018 (comment).

@kwonoj
Copy link
Copy Markdown
Member

kwonoj commented Dec 10, 2015

Get it, thanks. (Just clarify, it wasn't suggestion to delete it, purely based on curiosity)

@robwormald
Copy link
Copy Markdown
Contributor Author

robwormald commented Dec 10, 2015

Yeah, I hadn't even considered that option, haha!

On Dec 9, 2015, at 4:44 PM, OJ Kwon [email protected] wrote:

Get it, thanks. (Just clarify, it wasn't suggestion to delete it, purely based on curiosity)

—
Reply to this email directly or view it on GitHub #1018 (comment).

@kwonoj
Copy link
Copy Markdown
Member

kwonoj commented Dec 10, 2015

I think changes good for immediate solution. (sorry, may require rebase due to my latest check in).

@robwormald
Copy link
Copy Markdown
Contributor Author

robwormald commented Dec 10, 2015

whoops, screwed up that merge. fixing...
oops

@benlesh
Copy link
Copy Markdown
Member

benlesh commented Dec 10, 2015

file mode changed

@robwormald
Copy link
Copy Markdown
Contributor Author

robwormald commented Dec 10, 2015

okay, good to go.

@kwonoj
Copy link
Copy Markdown
Member

kwonoj commented Dec 10, 2015

Cool, I'll check in in today once travis says good to go.

@kwonoj kwonoj merged commit 676f82d into ReactiveX:master Dec 10, 2015
@kwonoj
Copy link
Copy Markdown
Member

kwonoj commented Dec 10, 2015

Merged with 676f82d, appreciate @robwormald !

@lock lock Bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type Definitions are empty for "add" modules

3 participants

@robwormald @kwonoj @benlesh