Skip to content

3.x: remove unnecessary static imports from unit tests #6550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 1 commit into from
Jul 3, 2019
Merged

3.x: remove unnecessary static imports from unit tests #6550

akarnokd merged 1 commit into from
Jul 3, 2019

Conversation

@slievrly
Copy link
Contributor

@slievrly slievrly commented Jun 29, 2019 •
edited by akarnokd
Loading

Remove unnecessary static imports from unit tests.

@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #6550 into 3.x will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6550      +/-   ##
============================================
+ Coverage     98.19%   98.24%   +0.04%     
- Complexity     6197     6201       +4     
============================================
  Files           682      682              
  Lines         45459    45459              
  Branches       6288     6288              
============================================
+ Hits          44637    44659      +22     
+ Misses          276      259      -17     
+ Partials        546      541       -5
Impacted Files Coverage Δ Complexity Δ
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...ernal/operators/flowable/FlowableFromIterable.java 95.18% <0%> (-2.14%) 5% <0%> (ø)
...nternal/operators/parallel/ParallelReduceFull.java 93.06% <0%> (-1.99%) 2% <0%> (ø)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...nternal/operators/observable/ObservableCreate.java 97.43% <0%> (-1.71%) 2% <0%> (ø)
...tivex/internal/operators/single/SingleTimeout.java 98.33% <0%> (-1.67%) 2% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-1.2%) 2% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.36% <0%> (-1.07%) 9% <0%> (ø)
...perators/mixed/ObservableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 3% <0%> (ø)
...internal/operators/flowable/FlowableSwitchMap.java 95.75% <0%> (-0.95%) 3% <0%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc7fce8...0c2df9b. Read the comment docs.

@akarnokd akarnokd added this to the 3.0 milestone Jun 29, 2019
@akarnokd akarnokd merged commit 335ee34 into ReactiveX:3.x Jul 3, 2019
@akarnokd akarnokd mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akarnokd akarnokd akarnokd approved these changes

+1 more reviewer

@vanniktech vanniktech vanniktech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3.x Cleanup Test

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@slievrly @akarnokd @vanniktech