Skip to content

2.x: Improve subjects and processors package doc #6434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akarnokd merged 1 commit into from
Mar 18, 2019
Merged

2.x: Improve subjects and processors package doc #6434

akarnokd merged 1 commit into from
Mar 18, 2019

Conversation

@akarnokd
Copy link
Member

@akarnokd akarnokd commented Mar 18, 2019

  • Fix a typo in the subjects doc
  • Expand the processors doc

@akarnokd akarnokd added this to the 2.2 backlog milestone Mar 18, 2019
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #6434 into 2.x will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6434      +/-   ##
============================================
+ Coverage     98.24%   98.26%   +0.01%     
- Complexity     6294     6296       +2     
============================================
  Files           675      675              
  Lines         45172    45172              
  Branches       6246     6246              
============================================
+ Hits          44380    44389       +9     
+ Misses          250      242       -8     
+ Partials        542      541       -1
Impacted Files Coverage Δ Complexity Δ
...l/operators/observable/ObservableFlatMapMaybe.java 89.54% <0%> (-6.54%) 2% <0%> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...va/io/reactivex/internal/queue/SpscArrayQueue.java 97.61% <0%> (-2.39%) 22% <0%> (-1%)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...rnal/operators/observable/ObservableSwitchMap.java 94.68% <0%> (-1.6%) 3% <0%> (ø)
...x/internal/operators/flowable/FlowableFlatMap.java 88.42% <0%> (-1.32%) 4% <0%> (ø)
...activex/internal/schedulers/ExecutorScheduler.java 95.97% <0%> (-1.01%) 10% <0%> (ø)
...perators/observable/ObservableMergeWithSingle.java 99.06% <0%> (-0.94%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 98.29% <0%> (-0.86%) 2% <0%> (ø)
...x/internal/operators/flowable/FlowablePublish.java 96.2% <0%> (-0.43%) 11% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb7b4d...9f8f1ee. Read the comment docs.

@akarnokd akarnokd merged commit 0c4f5c1 into ReactiveX:2.x Mar 18, 2019
@akarnokd akarnokd deleted the JavadocCleanup0318a branch March 18, 2019 11:33
@akarnokd akarnokd mentioned this pull request Mar 21, 2019
Closed
@akarnokd akarnokd mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vanniktech vanniktech vanniktech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.x Cleanup Documentation

Projects

None yet

Milestone

2.2 backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@akarnokd @vanniktech