Fix std::result_of removed in C++20#551
Merged
kirkshoop merged 2 commits intoReactiveX:masterfrom Aug 26, 2021
Asaaj:master
Merged
Fix std::result_of removed in C++20#551kirkshoop merged 2 commits intoReactiveX:masterfrom Asaaj:master
kirkshoop merged 2 commits intoReactiveX:masterfrom
Asaaj:master
Conversation
Contributor
Author
|
I wanted a simpler change than #545, which apparently failed. This seems safer to me |
Contributor
Author
|
I've never worked with AppVeyor before, but is it reasonably straightforward to get it building with VS2019? Or is RxCpp not claiming to support that version of VS? I can guess what changes are required in appveyor.yml, but I'm not sure the protocol here. |
Contributor
Author
|
@kirkshoop with C++20 approaching completion on all major compilers, it would be great to get this fix tested and released soon so this library doesn't gate those who want to upgrade (myself included). |
|
@kirkshoop please 🙏 my C++20 project needs this |
|
Update: Here's a quick workaround, before importing rx.hpp have this: |
|
❤️ |
|
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #530, intended to be as minimal as possible. Further testing is required, but I wanted to get this in for discussion.