Fixed build interface include directories for CMake projects#536
Merged
kirkshoop merged 1 commit intoReactiveX:masterfrom Aug 22, 2020
Merged
Fixed build interface include directories for CMake projects#536kirkshoop merged 1 commit intoReactiveX:masterfrom
kirkshoop merged 1 commit intoReactiveX:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
I am using RxCpp in my CMake project, having it added as a git submodule and connected to my project via cmake 'add_subdirectory'. I had initial problems as it seems that the cmake BUILD_INTERFACE was pointing to the non-existent folder 'projects/CMake/include', and was a quick fix to point it to the proper location.
Thnx 😄