Changed values_from template parameter to not cast.#521
Merged
kirkshoop merged 1 commit intoReactiveX:masterfrom Jan 5, 2020
tinkerbeast:master
Merged
Changed values_from template parameter to not cast.#521kirkshoop merged 1 commit intoReactiveX:masterfrom tinkerbeast:master
kirkshoop merged 1 commit intoReactiveX:masterfrom
tinkerbeast:master
Conversation
The template has several uses as values_from<int, sizeof...(ParamN)>::type(). This causes a cast issue as the second paramter by default in an int whereas here we are passing a size_t.
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template has several uses as values_from<int, sizeof...(ParamN)>::type(). This causes a cast issue as the second parameter by default is an int whereas we are passing a size_t.