operators: Add ref_count(other) operator overload.#485
Merged
kirkshoop merged 1 commit intoReactiveX:masterfrom Mar 6, 2019
Merged
operators: Add ref_count(other) operator overload.#485kirkshoop merged 1 commit intoReactiveX:masterfrom
kirkshoop merged 1 commit intoReactiveX:masterfrom
Conversation
kirkshoop
reviewed
Feb 26, 2019
kirkshoop
requested changes
Feb 26, 2019
Member
kirkshoop
left a comment
kirkshoop
left a comment
There was a problem hiding this comment.
This is great, thank you! If you need help with the tests I am happy to work with you on them.
The existing `connectable_observable.ref_count()` operator calls
connect on the source when it's subscribed to.
Generalize this by allowing an optional parameter `other`, i.e.
`observable.ref_count(connectable_observable other)` to be used as the
connect target.
Useful for implementing diamond graphs while retaining composability:
```
A
/ \
B C
\ /
D
|
E
auto A = ... | publish();
auto B = A | ...;
auto C = A | ...;
auto D = B | merge(C) | ref_count(A);
auto E = D | ...;
E | subscribe(...);
```
Resolves: ReactiveX#484
kirkshoop
approved these changes
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
connectable_observable.ref_count()operator callsconnect on the source when it's subscribed to.
Generalize this by allowing an optional parameter
other, i.e.observable.ref_count(connectable_observable other)to be used as theconnect target.
Useful for implementing diamond graphs while retaining composability:
Resolves: #484