cmake: Fix 'make' generator targets#480
Merged
kirkshoop merged 1 commit intoReactiveX:masterfrom Feb 12, 2019
Merged
Conversation
Remove 'RxCpp' library target when it's used outside of Visual Studio. This was supposed to be a virtual target, not an actual one that builds libRxCpp.so. The build never worked because it was missing setting the compiler/linker flags from shared.cmake Resolves: ReactiveX#477
Contributor
Author
|
Maybe flake? Didn't see this CI failure on other PRs. |
Member
|
Yes, that was a flakey build. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove 'RxCpp' library target when it's used outside of
Visual Studio. This was supposed to be a virtual target,
not an actual one that builds libRxCpp.so.
The build never worked because it was missing setting the
compiler/linker flags from shared.cmake
Resolves: #477