Fix doc target missing declarations errors#464
Merged
kirkshoop merged 1 commit intoReactiveX:masterfrom Oct 20, 2018
Merged
Conversation
Building the docs (e.g. with `ninja doc`) failed with GCC (e.g. GCC 7.3
under Fedora 27) with some missing declaration errors.
Example:
../Rx/v2/examples/doxygen/main.cpp:7:13: error: no previous
declaration for ‘std::__cxx11::string get_pid()’
[-Werror=missing-declarations]
Thus, this change adds a shared declaration for `get_pid()` that is
included by all users/the file where it's defined such that
accidental deviation in the signature are immediately noticed (as
compile error).
Similarly, the visibility of the example `less()` is changed to static
as it's only locally used.
With those changes the doc target succeeds again.
kirkshoop
approved these changes
Oct 20, 2018
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the docs (e.g. with
ninja doc) failed with GCC (e.g. GCC 7.3under Fedora 27) with some missing declaration errors.
Example:
Thus, this change adds a shared declaration for
get_pid()that isincluded by all users/the file where it's defined such that
accidental deviation in the signature are immediately noticed (as
compile error).
Similarly, the visibility of the example
less()is changed to staticas it's only locally used.
With those changes the doc target succeeds again.