Skip to content

Add get_subscription() for subject#381

Merged
kirkshoop merged 1 commit intoReactiveX:masterfrom
wutiantong:master
Jun 5, 2017
Merged

Add get_subscription() for subject#381
kirkshoop merged 1 commit intoReactiveX:masterfrom
wutiantong:master

Conversation

@wutiantong
Copy link
Copy Markdown

I think this little code piece is harmless and meaningful.

Further explaining, there are two constructor of subject:

    subject()
        : s(composite_subscription())
    {
    }
    explicit subject(composite_subscription cs)
        : s(cs)
    {
    }

to retrieve the auto-created subscription(in 1st constructor), we need a get_subscription() for subject.

@kirkshoop
Copy link
Copy Markdown
Member

I would expect that this subscription was already available by calling get_subscriber().get_subscription() but this is convenient.

Thanks!

@kirkshoop kirkshoop merged commit a1730f9 into ReactiveX:master Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants