Avoid using copying property as a block value#506
Merged
jspahrsummers merged 1 commit intoReactiveCocoa:masterfrom May 22, 2013
Merged
Avoid using copying property as a block value#506jspahrsummers merged 1 commit intoReactiveCocoa:masterfrom
jspahrsummers merged 1 commit intoReactiveCocoa:masterfrom
Conversation
This may fix ReactiveCocoa#505 leak issue.
Member
|
As far as I can tell by using it in a sample app, this fixes #505, so it looks ok to me. |
jspahrsummers
added a commit
that referenced
this pull request
May 22, 2013
Member
|
This does indeed fix it. I don't understand why either. Thanks for the fix, though! 🌟 |
Closed
Member
|
There are other uses of |
Member
|
Tentatively, I think we should just keep this in mind. I haven't seen any other leaks. Maybe there's just something weird with how we override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may fix #505 leak issue.
I'm sorry but I can not explain why this patch could fix the leak.
It is my bad know-how.