fix(ubuntu): verify command line tools is the version we want#411
Closed
mikehardy wants to merge 1 commit intoReactiveCircus:mainfrom
mikehardy:ubuntu-24-cmdline-tools-latest
Closed
fix(ubuntu): verify command line tools is the version we want#411mikehardy wants to merge 1 commit intoReactiveCircus:mainfrom mikehardy:ubuntu-24-cmdline-tools-latest
mikehardy wants to merge 1 commit intoReactiveCircus:mainfrom
mikehardy:ubuntu-24-cmdline-tools-latest
Conversation
Contributor
Author
|
This quieted down the sdkmanager errors related to XML version 4 being seen but tools only supporting up to version 3 |
the directory merely existing is not sufficient to say command line tools will work, it may be an old version get the version and explicitly check it, remove it so fresh install will happen if it is not the desired version
Contributor
Author
|
I updated this to main and made it so you can disable it with an input boolean, but I believe it is already causing a correctness issue so I left it as default true (correctness >> performance). Ready for review and either adoption or we can close if not interested @ychescale9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion with @ychescale9 - optionally update the cmdline-tools package if it is not the correct version
Right now there is a difference in the sdkmanager XML versions distributed by servers (v4) and handled by ubuntu-24 runner image pre-installed cmdline-tools sdkmanager (only handles v3), so this is already a problem, and for that reason I set the default to "true" - correctness over performance
But people can toggle it off if they want