Skip to content

Tree gen cyclopentadiene scission#498

Merged
amarkpayne merged 3 commits intomainfrom
tree_gen_cyclopentadiene_scission
Oct 18, 2021
Merged

Tree gen cyclopentadiene scission#498
amarkpayne merged 3 commits intomainfrom
tree_gen_cyclopentadiene_scission

Conversation

@hwpang
Copy link
Copy Markdown
Contributor

@hwpang hwpang commented Jun 21, 2021

Tree generated during RMG developer hour using tree generation notebook

@hwpang hwpang requested a review from mjohnson541 June 21, 2021 15:34
@amarkpayne amarkpayne changed the base branch from master to main October 18, 2021 16:14
Copy link
Copy Markdown
Member

@amarkpayne amarkpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Go ahead and rebase

@hwpang hwpang force-pushed the tree_gen_cyclopentadiene_scission branch from 2c3ead3 to 20c0232 Compare October 18, 2021 16:21
@hwpang
Copy link
Copy Markdown
Contributor Author

hwpang commented Oct 18, 2021

@amarkpayne Thanks for the review! I have rebased onto the current main branch!

@hwpang hwpang force-pushed the tree_gen_cyclopentadiene_scission branch from 20c0232 to aaccd98 Compare October 18, 2021 16:30
@hwpang
Copy link
Copy Markdown
Contributor Author

hwpang commented Oct 18, 2021

@amarkpayne I have dropped the committed reaction.py from the tree gen commit!

@amarkpayne amarkpayne merged commit 17a08f0 into main Oct 18, 2021
@amarkpayne amarkpayne deleted the tree_gen_cyclopentadiene_scission branch October 18, 2021 17:25
@amarkpayne
Copy link
Copy Markdown
Member

Thanks for the PR @hwpang !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants