Port Optional RMS Changes into Ongoing SciPy CLAR Implementation#2735
Merged
JacksonBurns merged 11 commits intoReactionMechanismGenerator:feat/resonance_scipyfrom Nov 20, 2024
Conversation
when it is missing
also update the final run example - the point of specifying the `PYTHONPATH` was so that users _don't_ have to give the full path to `rmg.py` - the `python` executable can search it out
- clearer error messages Co-authored-by: Hao-Wei Pang <[email protected]>
JacksonBurns
merged commit 8e9f4ec
into
ReactionMechanismGenerator:feat/resonance_scipy
Contributor
Author
|
Manually resolved locally and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't debug the CLAR implementation right now because the new
juliaupbased installation isn't working. Going to allow running without Julia on this PR, which we were planning on doing in the future, and then add support back for it later. Can't fix two things at once.