@hwpang I added the fragment and rms fragment regression to the other line in the CI file makes it run the regression_input comparison

Thanks!

Codecov Report

Merging #2571 (b324104) into main (3183e4b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2571   +/-   ##
=======================================
  Coverage   55.44%   55.44%           
=======================================
  Files         124      124           
  Lines       36818    36818           
=======================================
  Hits        20414    20414           
  Misses      16404    16404           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hwpang so the CI is failing for two reasons:

1. The new RMS+fragment regression test has never been run on main, so there are no regression results to do the baseline comparison.
2. The fragment regression test is raising an actual error about a missing file in the reference results, see https://github.com/ReactionMechanismGenerator/RMG-Py/actions/runs/6737504658/job/18315100139#step:17:482

Can you take a look at 2. and help me figure out what went wrong?

@hwpang so the CI is failing for two reasons:

1. The new RMS+fragment regression test has never been run on main, so there are no regression results to do the baseline comparison.
2. The fragment regression test is raising an actual error about a missing file in the reference results, see https://github.com/ReactionMechanismGenerator/RMG-Py/actions/runs/6737504658/job/18315100139#step:17:482

Can you take a look at 2. and help me figure out what went wrong?

Yeah! This is because the saveEdgeSpecies option in the input.py needs to be turned on. I pushed a commit to change that in both input files.

Yeah! This is because the saveEdgeSpecies option in the input.py needs to be turned on. I pushed a commit to change that in both input files.

Thanks for the quick fix!

I got @JacksonBurns's offline approval to merge this in. The failure in CI for fragment + simple reactor is because the edge was not saved in the stable run due to not setting saveEdgeSpecies to True. The failure in CI for fragment + RMS reactor is because no stable version to compare to yet.