hack to allow comments on PRs to RMG-Py from forks#2502
Closed
JacksonBurns wants to merge 5 commits intoReactionMechanismGenerator:mainfrom
Closed
hack to allow comments on PRs to RMG-Py from forks#2502JacksonBurns wants to merge 5 commits intoReactionMechanismGenerator:mainfrom
JacksonBurns wants to merge 5 commits intoReactionMechanismGenerator:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2502 +/- ##
=======================================
Coverage 48.54% 48.54%
=======================================
Files 110 110
Lines 30812 30812
Branches 8054 8054
=======================================
Hits 14959 14959
- Misses 14329 14330 +1
+ Partials 1524 1523 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
I think the approach now in #2501 is simpler and perhaps more reliable (now that it's finally working). |
Contributor
Author
|
Closing in favor of #2501 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2501