Revert libstdcxx-ng Patches in CI, Docs, and Dockerfile#2469
Merged
rwest merged 2 commits intoReactionMechanismGenerator:mainfrom Jun 15, 2023
Merged
Revert libstdcxx-ng Patches in CI, Docs, and Dockerfile#2469rwest merged 2 commits intoReactionMechanismGenerator:mainfrom
libstdcxx-ng Patches in CI, Docs, and Dockerfile#2469rwest merged 2 commits intoReactionMechanismGenerator:mainfrom
Conversation
…cxx-ng patches) a new version of Julia has been released that fixes the issue we were facing, so these changes are no longer needed (see issue ReactionMechanismGenerator#2455 and PR ReactionMechanismGenerator#2456)
JacksonBurns
added
the
Status: Ready for Review
rwest
previously approved these changes
Jun 15, 2023
Member
rwest
left a comment
rwest
left a comment
There was a problem hiding this comment.
If this runs ok then it looks good to me (with one question/comment about requiring the Mac tests to pass)
Contributor
Author
|
@rwest this will require changing the required checks back to just |
rwest
approved these changes
Jun 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #2469 +/- ##
==========================================
- Coverage 48.29% 48.24% -0.05%
==========================================
Files 110 110
Lines 30726 30726
Branches 8032 8032
==========================================
- Hits 14838 14824 -14
- Misses 14356 14370 +14
Partials 1532 1532 see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
We forgot to do the documentation building CI job |
rwest
removed
the
Status: Ready for Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a new version of Julia has been released that fixes the issue we were facing, so these changes are no longer needed (see issue #2455 and PR #2456).
I have added that version of Julia (1.9.0) to the "do not allow" list for the environment file. We could probably find a way to specifically disallow the problematic build instead, but this is easier.
With this CI update in place, we can look to figure out the issue with regression testing and then finally get the updated CI into RMG-database.