Remove chemprop-dependent Code#2450
Remove chemprop-dependent Code#2450JacksonBurns wants to merge 1 commit intoReactionMechanismGenerator:py311from
chemprop-dependent Code#2450Conversation
|
This commit might be helpful in fixing this first failed CI run. |
|
Note from the RMG developers meeting - the |
conda-forge build of chemprop instead of rmgchemprop-dependent Code
|
For the transition to Python 3.11, features requiring
There is also discussion of build a more flexible interface to ML-based estimators, such that the estimator itself would not be distributed with RMG but would just need to inherit from some ML Estimator class in RMG that defines a |
|
This pull request is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant pull request, otherwise it will automatically be closed in 30 days. |
|
|
Motivation or Problem
As discussed in #2445 our build of
chempropis very old and does not support Python 3.11, which will prevent us from doing so as well.Description of Changes
Right now the only change is to switch the channel in
environment.ymlfromrmgtoconda-forgeforchemprop. This will likely break other code inRMG-Pyand require additional changes afterward.Testing
I have done a
--dry-runof resolving this environment file so that at least works, but there will be other things to fix as revealed by the CI.Notes
This PR will later need to be followed by an
upgradePR (as part of #2445) to move to chemprop v2, which will support Python 3.11