Refactoring fragment.py for better maintainability and style#2360
Closed
JacksonBurns wants to merge 1 commit intoReactionMechanismGenerator:mainfrom
Closed
Refactoring fragment.py for better maintainability and style#2360JacksonBurns wants to merge 1 commit intoReactionMechanismGenerator:mainfrom
fragment.py for better maintainability and style#2360JacksonBurns wants to merge 1 commit intoReactionMechanismGenerator:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2360 +/- ##
==========================================
- Coverage 48.38% 47.70% -0.68%
==========================================
Files 110 110
Lines 30517 30517
Branches 7951 7951
==========================================
- Hits 14765 14558 -207
- Misses 14211 14443 +232
+ Partials 1541 1516 -25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
Output of Command output: |
295ef99 to
27c5aca
Compare
Contributor
Author
|
Migrating this to a branch on RMG-Py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working with @lily90502 to take better advantage of existing infrastructure in RMG to make the new fragment features more maintainable and extensible.