Conversation
Codecov Report
@@ Coverage Diff @@
## master #1825 +/- ##
=======================================
Coverage 43.02% 43.02%
=======================================
Files 80 80
Lines 21099 21099
Branches 5516 5516
=======================================
Hits 9077 9077
+ Misses 11004 10990 -14
- Partials 1018 1032 +14
Continue to review full report at Codecov.
|
amarkpayne
approved these changes
Dec 4, 2019
Member
amarkpayne
left a comment
amarkpayne
left a comment
There was a problem hiding this comment.
This looks good, can you rebase?
This was referenced Dec 13, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
Adding Iodine in the elements section of the chemkin input file
Description of Changes
file chemkin.pyx in rmgpy folder.
s = 'ELEMENTS\n'
Testing
A clear and concise description of testing that you've done or plan to do.
Reviewer Tips
Suggestions for verifying that this PR works or other notes for the reviewer.