Conversation
Merged
alongd
reviewed
Nov 5, 2019
Member
alongd
left a comment
alongd
left a comment
There was a problem hiding this comment.
Thanks! I added some comments.
Codecov Report
@@ Coverage Diff @@
## master #1808 +/- ##
=======================================
Coverage 43.02% 43.02%
=======================================
Files 80 80
Lines 21099 21099
Branches 5516 5516
=======================================
Hits 9077 9077
+ Misses 11004 10990 -14
- Partials 1018 1032 +14
Continue to review full report at Codecov.
|
In older versions of matplotlib, figures had a method close. They do not anymore, so this has been updated to allow the figures to close (and memory released)
goldmanm
force-pushed
the
arkane_pdep_py3
branch
from
bd54244 to
e6d246a
Compare
alongd
approved these changes
Nov 20, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
I ran a pdep job on Python 3 and encountered some small issues. This commit fixed these bugs.
Description of Changes
Figure.close no longer works, so this commit changes how to close the figure. It also renames a variable for consistency.
Testing
Ran an RMG pdep job and got the expected result.
Reviewer Tips
Make sure the code looks adequate