Merged
Conversation
goldmanm
force-pushed
the
isotope_documentation_updates
branch
from
39525f8 to
dbc2baa
Compare
Codecov Report
@@ Coverage Diff @@
## master #1807 +/- ##
=======================================
Coverage 43.02% 43.02%
=======================================
Files 80 80
Lines 21099 21099
Branches 5516 5516
=======================================
Hits 9077 9077
+ Misses 11004 10990 -14
- Partials 1018 1032 +14
Continue to review full report at Codecov.
|
alongd
reviewed
Nov 20, 2019
Member
alongd
left a comment
alongd
left a comment
There was a problem hiding this comment.
Thanks, I added minor comments
|
|
||
| A description of mechanisms generated using this module and its application to | ||
| obtaining intramolecular isotopic enrichment information is described in | ||
| Chemical Geology, Volume 514, page 1, doi: https://doi.org/10.1016/j.chemgeo.2019.02.036 |
Member
There was a problem hiding this comment.
could you make these doi's clickable?
use this example format for rst:
`Molpro <https://www.molpro.net/>`_
Contributor
Author
There was a problem hiding this comment.
fixed and checked to ensure it built properly with links
This commit updates the isotope documentation by linking a publication and its corresponding scripts, as well as mentioning a caveat when regenerating all the reactions from the start.
goldmanm
force-pushed
the
isotope_documentation_updates
branch
from
dbc2baa to
2d0def3
Compare
alongd
approved these changes
Nov 20, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the isotope documentation by linking a publication
and its corresponding scripts, as well as mentioning a caveat when
regenerating all the reactions from the start.
Testing
Built locally, checked spelling, viewed in browser, made sure links function
Reviewer Tips
See if the writing makes sense.