Minor: updated parts of the commented input.py file#1806
Merged
amarkpayne merged 1 commit intomasterfrom Nov 19, 2019
Merged
Conversation
amarkpayne
reviewed
Nov 18, 2019
Member
amarkpayne
left a comment
amarkpayne
left a comment
There was a problem hiding this comment.
This all looks fine to me. Rebase to update this branch and I'll merge this in
kspieks
force-pushed
the
update_commented_input_file
branch
from
aa68f7e to
2fce686
Compare
Codecov Report
@@ Coverage Diff @@
## master #1806 +/- ##
=======================================
Coverage 43.02% 43.02%
=======================================
Files 80 80
Lines 21099 21099
Branches 5516 5516
=======================================
Hits 9077 9077
+ Misses 11004 10990 -14
- Partials 1018 1032 +14
Continue to review full report at Codecov.
|
amarkpayne
approved these changes
Nov 19, 2019
Member
|
@mliu49 I was about to merge these changes, but I just saw your "for next release tag". How should I proceed? |
Member
|
Ah, unless this is for stuff that is meant for the 3.0 release as opposed to the 3.1 release. |
Contributor
|
Yeah, the tag refers to the 3.0 release. Suggestions for better label names are welcome. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
Resolves the very minor issue in #1801 in which the commented input.py file was missing some descriptions.
Description of Changes
I added some of these descriptions to the commented input.py file. I now realize that looking at RMG-Py/rmgpy/rmg/input.py is probably the best template for generating a new input file.
Testing
No testing was performed since the commented input file is never run
Reviewer Tips
None