Merged
Conversation
yunsiechung
previously approved these changes
Nov 4, 2019
Contributor
yunsiechung
left a comment
yunsiechung
left a comment
There was a problem hiding this comment.
Everything looks good to me!
oscarwumit
force-pushed
the
sensitivity_py3_example_update
branch
from
6645728 to
9c86874
Compare
Codecov Report
@@ Coverage Diff @@
## master #1805 +/- ##
=======================================
Coverage 42.99% 42.99%
=======================================
Files 80 80
Lines 21090 21090
Branches 5513 5513
=======================================
Hits 9067 9067
Misses 11008 11008
Partials 1015 1015Continue to review full report at Codecov.
|
Two updates for the sensitivity example: 1. correct the format of chemkin input file in the example, before it resulted in a parser error "Thermo file has no default temperature ranges (The line it would be on is ' 300.000 1000.000 5000.000\n' but that is not formatted as such) " 2. removed legacy exclusion mark for kinetics families
oscarwumit
force-pushed
the
sensitivity_py3_example_update
branch
from
9c86874 to
e8b88be
Compare
Contributor
Author
|
@amarkpayne could you please merge this PR? I do not have merge access.Thanks. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
Update sensitivity example as part of py3 merge task.
Description of Changes
"Thermo file has no default temperature ranges
(The line it would be on is ' 300.000 1000.000 5000.000\n' but that is not formatted as such)
"
Testing
Tested the example locally. The sensitivity analysis finished successfully.