Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1769 +/- ##
=======================================
Coverage 32.61% 32.61%
=======================================
Files 87 87
Lines 26124 26124
Branches 6878 6878
=======================================
Hits 8521 8521
+ Misses 16644 16633 -11
- Partials 959 970 +11
Continue to review full report at Codecov.
|
mjohnson541
reviewed
Oct 28, 2019
Contributor
mjohnson541
left a comment
mjohnson541
left a comment
There was a problem hiding this comment.
Mostly looks good, one question about the last commit.
arkane/statmech.py
Outdated
| 'ccsd(t)-f12/aug-cc-pvtz': 0.998, # [3], taken as CCSD(T)-F12a/cc-pVTZ-F12 | ||
| 'ccsd(t)-f12/aug-cc-pvqz': 0.998, # [3], taken as 'CCSD(T)-F12b/VQZF12//CCSD(T)-F12a/TZF' | ||
| } | ||
| freq_level.replace('**', '(d,p)') |
Contributor
There was a problem hiding this comment.
I don't think I understand, why do we want to use BAC from one basis set and freq scaling factor from a different basis?
Member
Author
|
I removed the |
mjohnson541
approved these changes
Oct 30, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
The current Arkane output is not in a format that can be directly pasted into RMG libraries. See #1768
Description of Changes
Now Arkane will output thermo and kinetic libraries into an RMG_libraries folder. Note that only species with structure will be considered for the thermo library, and only reactions with structures for all their reactants and products will be considered for the kinetics libarry.
Testing
Added a unit test for an intermediate newly added function, could add functional tests as well.
Reviewer Tips
Run a thermo job, specifying structure for a species, and see the resulting thermo library.
Run kinetics and pdep jobs, specifying structures for all species, and see the resulting kinetics library.