Update documentation from py2 to py3#1767
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1767 +/- ##
=======================================
Coverage 32.61% 32.61%
=======================================
Files 87 87
Lines 26124 26124
Branches 6878 6878
=======================================
Hits 8521 8521
+ Misses 16644 16633 -11
- Partials 959 970 +11
Continue to review full report at Codecov.
|
rmgpy/molecule/atomtype.py
Outdated
| """ | ||
|
|
||
| def __init__(self, label='', | ||
| def __init__(self, label=``, |
There was a problem hiding this comment.
I think you probably didn't intend to replace all ' with ` in this file?
There was a problem hiding this comment.
@mliu49 I only intended to change the ' in the docstring block. I've recovered those that should have remained '.
|
Thanks for the PR @hwpang ! I hope you don't mind I have pushed two additional commits that update the installation section of the documentation now that we are using python 3. |
|
Thank you! I hope this is the right pull request to update the description for the RMG-database scripts with Python 3? |
Yes, thanks @ajocher ! |
documentation/source/users/rmg/installation/anacondaDeveloper.rst
Outdated
Show resolved
Hide resolved
|
I pushed a few more fixes to the documentation. Please review the new changes and squash when ready. I think the other changes look good. |
amarkpayne
left a comment
amarkpayne
left a comment
There was a problem hiding this comment.
These additional changes look good to me. @hwpang can you rebase this branch to update to master and squash some of the commits? Otherwise I think this PR is ready to go and can get merged in today.
Also, make the links stand out more
As well as generall additions for improved clarity
|
I squashed and rebased on master. The last two commits are new. |
4 participants
Motivation or Problem
Update documentation from py2 to py3 and fix some wrong import directory.
Description of Changes
A clear and concise description of what what you've changed or added.
Testing
After changes,
make htmlbuildsbuild/html/for RMG-Py3 successfully.Reviewer Tips
Suggestions for verifying that this PR works or other notes for the reviewer.
fixes #1772