Make page titles contain current release number instead of 2.1.0#1680
Merged
mjohnson541 merged 1 commit intomasterfrom Aug 9, 2019
Merged
Make page titles contain current release number instead of 2.1.0#1680mjohnson541 merged 1 commit intomasterfrom
mjohnson541 merged 1 commit intomasterfrom
Conversation
…1.0 Documentation" Pages currently have a title that's something like `<title>Arkane (arkane) — RMG-Py 2.1.0 Documentation</title>` which clearly we forget to update with new version numbers. This should automatically update it with the release version.
mliu49
approved these changes
Aug 9, 2019
Contributor
mliu49
left a comment
mliu49
left a comment
There was a problem hiding this comment.
Thanks for catching this!
Codecov Report
@@ Coverage Diff @@
## master #1680 +/- ##
==========================================
+ Coverage 41.79% 41.81% +0.01%
==========================================
Files 177 177
Lines 30207 30207
Branches 6252 6252
==========================================
+ Hits 12625 12630 +5
+ Misses 16659 16655 -4
+ Partials 923 922 -1
Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pages currently have a title that's something like
<title>Arkane (arkane) — RMG-Py 2.1.0 Documentation</title>which clearly we forget to update with new version numbers.
This should automatically update it with the release version.
The titles are not prominent in some browsers, but are very obvious in google search results etc.