Check numpy version before passing rcond to numpy.linalg.lstsq#1670
Merged
amarkpayne merged 3 commits intomasterfrom Jul 29, 2019
Merged
Check numpy version before passing rcond to numpy.linalg.lstsq#1670amarkpayne merged 3 commits intomasterfrom
amarkpayne merged 3 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1670 +/- ##
==========================================
+ Coverage 41.88% 41.88% +<.01%
==========================================
Files 176 176
Lines 29368 29369 +1
Branches 6059 6059
==========================================
+ Hits 12301 12302 +1
Misses 16188 16188
Partials 879 879
Continue to review full report at Codecov.
|
Prior to numpy 1.14, numpy.linag.lstsq does not accept rcond=None and will raise a TypeError. In numpy 1.14 and after, None requests the new default behavior.
Contributor
Author
|
I've confirmed that this works with numpy 1.11 |
amarkpayne
approved these changes
Jul 29, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
#1659 added the
rcondargument to calls tonumpy.linalg.lstsq. A side-effect is that we broke compatibility with numpy versions prior to 1.14.Original plan was to simply increase our numpy version requirement, but after thinking about it a bit more, this change does not seem like sufficient reason to do so.
Description of Changes
This PR adds automatic determination of the appropriate value for rcond depending on the numpy version.
It also updates and futurizes
utilities.py.Testing
Will test in an environment with an older version of numpy. Travis should be sufficient to test that it works in newer versions of numpy.