Modified the Arkane ScanLog documentation#1650
Merged
amarkpayne merged 2 commits intomasterfrom Jul 12, 2019
Merged
Conversation
Merged
amarkpayne
approved these changes
Jul 12, 2019
Member
amarkpayne
left a comment
There was a problem hiding this comment.
Looks good! I'll merge this once the tests have passed.
Codecov Report
@@ Coverage Diff @@
## master #1650 +/- ##
==========================================
+ Coverage 41.8% 41.82% +0.01%
==========================================
Files 177 177
Lines 29455 29455
Branches 6059 6059
==========================================
+ Hits 12314 12319 +5
+ Misses 16271 16267 -4
+ Partials 870 869 -1
Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a short description of
Angleand its units when a ScanLog is read from a text file.Also corrected a minor typo in common.py